Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GitHub Actions for linting and unit tests #2819

Merged
merged 9 commits into from Jan 29, 2021

Conversation

chrisveilleux
Copy link
Member

Description

Build upon the work done in PR 2764 to replace Travis CI with GitHub Actions. Moved code coverage from coveralls to codecov due to some issues coveralls has with pytest and GitHub Actions.

How to test

You can see the results of the GitHub Actions workflow in draft PR 2817. The "build" and "coverage" badges in README.md were replaced with GitHub Actions and codecov badges.

Contributor license agreement signed?

CLA [Y]

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jan 27, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund
Copy link
Collaborator

Awesome! Should the .travis.yml and .coveralls.yml be removed as part of this as well?

@chrisveilleux
Copy link
Member Author

Awesome! Should the .travis.yml and .coveralls.yml be removed as part of this as well?

Good call, Åke. Will remove.

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and we are ready to roll!

@krisgesling krisgesling merged commit 4ad1a49 into dev Jan 29, 2021
@krisgesling krisgesling deleted the feature/github-actions-ci branch January 29, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants