Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of the Google Cloud TTS #2895

Closed
wants to merge 2 commits into from

Conversation

dsborets
Copy link

@dsborets dsborets commented May 3, 2021

Add support of the Google Cloud TTS https://cloud.google.com/text-to-speech

Sample config:

"google_cloud": {
      "file_format": "mp3",
      "lang": "en_GB",
      "service_account_info": {
         "type": "service_account",
         "project_id": "<project id>",
         "private_key_id": "<private key id>",
         "private_key": "<private key>"
         "client_email": "<client email>",
         "client_id": "<client id>",
         "auth_uri": "https://accounts.google.com/o/oauth2/auth",
         "token_uri": "https://oauth2.googleapis.com/token",
         "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
         "client_x509_cert_url": "<client cert URL>"
      }
    }

@pep8speaks
Copy link

pep8speaks commented May 3, 2021

Hello @dsborets! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-03 17:12:35 UTC

@devops-mycroft
Copy link

Hello, @dsborets, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label May 3, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

1 similar comment
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund
Copy link
Collaborator

forslund commented May 5, 2021

Hi, this is really awesome.

The project is moving towards more of a plugin based system so these don't need to be included in core. Last I heard many of the existing ones are planned to be removed and replaced by plugins (see #2701).

The docs for the plugins are here: https://mycroft-ai.gitbook.io/docs/mycroft-technologies/mycroft-core/plugins and an example of a TTS-plugin can be found here: https://github.com/JarbasLingua/jarbas-tts-plugin-voicerss

@dsborets
Copy link
Author

dsborets commented May 6, 2021

Ok, got it. I'll create a plugin instead. Is there any particular repo for plugins?

@JarbasAl
Copy link
Contributor

JarbasAl commented May 6, 2021

@dsborets the closest would be https://github.com/ChanceNCounter/awesome-mycroft-community#plugins-stt--tts-alternatives-containers--packages

i think there are plans to add plugins to the official marketplace also

@devs-mycroft devs-mycroft added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels May 12, 2021
@krisgesling
Copy link
Contributor

Hi @dsborets thanks for your efforts to add support for Google Cloud TTS.

I'll close this PR as a plugin is the best way to go for this now and it sounds like you're already heading down that path. Hopefully the documentation and other plugins have provided some good guidance.

@tolnai
Copy link

tolnai commented Feb 13, 2022

@dsborets , I just came across this PR as I was looking for how to enable google cloud TTS for mycroft. Did you eventually create a plugin version of your changes? (I couldn't find any.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants