#498 Automatically load data files #499

Merged
merged 3 commits into from Feb 10, 2017

Projects

None yet

2 participants

@forslund
Contributor
forslund commented Feb 7, 2017 edited

Load data files for skills automatically when loading the skill. Resolves #498

forslund added some commits Feb 4, 2017
@forslund forslund Load skill data nicely without throwing exceptions
Check if dialog and vocab dirs exist before trying to load files. Log an error if it fails.
8e46135
@forslund forslund Load data files from skill directory when loading skill. 476c302
@forslund forslund changed the title from Feature/issue 498 to Feature/issue #498 Automatically load data files Feb 7, 2017
@aatchison aatchison requested review from augustnmonteiro and aatchison Feb 9, 2017
@augustnmonteiro

This is a excellent idea. Let's remove self.load_data_files(dirname(__file__)) from the initialize of the skills.

@forslund
Contributor
forslund commented Feb 9, 2017

Sure, I'll remove it from all skills in the skills directory and update the PR

@forslund
Contributor

All loading of data files in the skills have been removed. I've tested as many skills as I've been able to and everything seems fine. I haven't been able to test the dial_call and send_sms skills but they should be fine.

@augustnmonteiro augustnmonteiro merged commit 56e2f6a into MycroftAI:dev Feb 10, 2017
@augustnmonteiro augustnmonteiro changed the title from Feature/issue #498 Automatically load data files to #498 Automatically load data files Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment