Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wifi setup changes #760

Merged
merged 4 commits into from May 16, 2017
Merged

Wifi setup changes #760

merged 4 commits into from May 16, 2017

Conversation

penrods
Copy link
Contributor

@penrods penrods commented May 16, 2017 •
edited

Several changes surrounding the wifi setup process:

  • The prompt to run wifi-setup is automatic on at startup if no connection detected
  • Mycroft-core can initiate the same prompt if internet is lost later
  • Skills manager doesn't attempt update unless connection is detected
  • Added translate-able dialog for hard-coded strings
  • Minor typo: it had "diferent" instead of "different"

penrods added 4 commits May 8, 2017 20:21
Restoring initial check for network and spoken prompt
2d6ac27 
The restores the initial check on bootup for network connectivity,
prompting the user to plug in the network cable or push the button
to start Wifi setup.

NOTE: This will need to be localized and handled by different
enclosures.
Stopping attempt to perform Skill Update unless connected to the inte…
c0f280e 
…rnet

Stopping attempt to perform Skill Update unless connected to the internet.  Also added translatable versions of spoken messages.
Merge branch 'dev' of https://github.com/MycroftAI/mycroft-core into dev
703a6b5
Correcting spelling error
d539412 
Fixed a typo:  "diferent" instead of "different"
@penrods penrods requested a review from kfezer May 16, 2017 18:17
aatchison
aatchison suggested changes May 16, 2017
View reviewed changes
Copy link
Contributor

@aatchison aatchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are many more files changed in the PR then intended

kfezer
kfezer approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@kfezer kfezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good to me.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 36.22% when pulling d539412 on feature/wifi-setup-typo into d68b1dd on dev.

@penrods penrods changed the title Correcting typo in wifi setup Wifi setup changes May 16, 2017
@penrods
Copy link
Contributor Author

penrods commented May 16, 2017

Updated the description, expanding it to general "wifi setup" changes.

@aatchison aatchison merged commit a14c267 into dev May 16, 2017
@aatchison aatchison deleted the feature/wifi-setup-typo branch May 16, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfezer kfezer kfezer approved these changes

@aatchison aatchison aatchison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@penrods @coveralls @kfezer @aatchison