New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converse method #925
converse method #925
Conversation
|
Thank you for breaking this out! This'll be way easier to digest. I'll work to get this reviewed and ready for the next build. |
|
i suppose we could avoid changing main, if we add listeners to core.py (handle_converse_request) and register the messages on bind(). then all skills would check if they were the target and if they were call converse method any advantage in that approach over changing main?
|
…converse Conflicts: mycroft/skills/core.py mycroft/skills/intent_service.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Add conversational support to skill system
The most recently used skills now have an opportunity to preview all
utterances before they hit the intent system.
==== Tech Notes ====
Skills get a preview in the order of activation -- most recent first --
and if they can consume the utterance or ignore it. If consumed,
processing stops. If ignored, the next most recent skill gets a shot
at it. Finally, if no skill consumes it the intent system takes over,
running as it always has.
Skills remain "active" for 5 minutes after last use.
A skill achieves this by implementing the converse() method, e.g.