Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tmdb-skill #890

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@builderjer
Copy link

commented Feb 24, 2019

Info

This PR adds the new skill, tmdb-skill, to the skills repo.

Description

Uses the TMDb api to call information about movies, actors, production companies and the like.

Created with mycroft-skills-kit v0.3.12

@builderjer

This comment has been minimized.

Copy link
Author

commented Feb 25, 2019

I read the checks, and I'm not sure why it failed. Can you explain?

@krisgesling

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

It appears to be problem with the alarm skills test suite. We've been having a little trouble with it lately. Let me check it out properly tomorrow and I'll let you know if there's actually a problem.

@krisgesling

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

If anyone else wants to look into it in the meantime, 008.delete.alarm.json appears to be returning dialog to cancel 1 alarm, when there should be 2 alarms still set.

@builderjer

This comment has been minimized.

Copy link
Author

commented Feb 25, 2019

I have submitted a couple of commits to this skill, mainly to clean up the code. Everything but line length is pep8 compatibale now, but I still don't see any errors.

I'm not sure I put them where the comment says, but I thought I did. If not, the latest code is in the main repo

@krisgesling

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Hey, to get those latest commits into this PR, just run
mycroft-msk upload /opt/mycroft/skills/your-skill

This will also re-run the tests.

No worries about the PEP8 line length either.

@builderjer builderjer force-pushed the builderjer:add-tmdb-skill branch from 57f6863 to 6e09a0f Feb 26, 2019

@builderjer

This comment has been minimized.

Copy link
Author

commented Feb 26, 2019

It looks like this skill passed the tests this time!!

I would love to get some feedback on this. Maybe some code streamlining?

@builderjer builderjer force-pushed the builderjer:add-tmdb-skill branch 2 times, most recently from b846b7c to 4d27536 Mar 3, 2019

@builderjer

This comment has been minimized.

Copy link
Author

commented Mar 3, 2019

I did a bug fix, and now it is not passing the tests. Once again, I don't think it is this skill, but the alarm skill

@builderjer builderjer force-pushed the builderjer:add-tmdb-skill branch 2 times, most recently from 5512308 to 2fe6246 Mar 5, 2019

@builderjer

This comment has been minimized.

Copy link
Author

commented Mar 9, 2019

Everything has passed, it would be great to get some feedback on this skill. @andlo , I added a couple more vocab and dialog files maybe you could translate for me and do a PR for them? That would be great!!

@builderjer builderjer force-pushed the builderjer:add-tmdb-skill branch 3 times, most recently from d327943 to 256b9df Mar 9, 2019

@forslund

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

Run test

@builderjer builderjer force-pushed the builderjer:add-tmdb-skill branch from 256b9df to 97c9f07 Mar 11, 2019

@builderjer

This comment has been minimized.

Copy link
Author

commented Mar 11, 2019

Nice!! Everything passed!!

@krisgesling

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Closing PR on old branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.