New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tmdb-skill #890
Add tmdb-skill #890
Conversation
|
I read the checks, and I'm not sure why it failed. Can you explain? |
|
It appears to be problem with the alarm skills test suite. We've been having a little trouble with it lately. Let me check it out properly tomorrow and I'll let you know if there's actually a problem. |
|
If anyone else wants to look into it in the meantime, |
|
I have submitted a couple of commits to this skill, mainly to clean up the code. Everything but line length is pep8 compatibale now, but I still don't see any errors. I'm not sure I put them where the comment says, but I thought I did. If not, the latest code is in the main repo |
|
Hey, to get those latest commits into this PR, just run This will also re-run the tests. No worries about the PEP8 line length either. |
57f6863
to
6e09a0f
Compare
|
It looks like this skill passed the tests this time!! I would love to get some feedback on this. Maybe some code streamlining? |
b846b7c
to
4d27536
Compare
|
I did a bug fix, and now it is not passing the tests. Once again, I don't think it is this skill, but the alarm skill |
5512308
to
2fe6246
Compare
|
Everything has passed, it would be great to get some feedback on this skill. @andlo , I added a couple more vocab and dialog files maybe you could translate for me and do a PR for them? That would be great!! |
d327943
to
256b9df
Compare
|
Run test |
256b9df
to
97c9f07
Compare
|
Nice!! Everything passed!! |
|
Closing PR on old branch. |
Info
This PR adds the new skill, tmdb-skill, to the skills repo.
Description
Uses the TMDb api to call information about movies, actors, production companies and the like.
Created with mycroft-skills-kit v0.3.12