Make time UI responsive for vertical or horizontal screen orientation #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works very well! Not sure if the design has been discussed earlier but maybe we could add some padding on top and bottom to make it more similar to the previous version? |
|
This looks much better, so will merge as is and can make further changes if desired. @dschweppe can weigh in on the design aspect. ie for landscape it would be: and portrait would retain the current: |
|
Yes, I agree with @krisgesling the stacked design should be reserved for Portrait displays and for landscape we should do side by side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make time ui responsive to vertical / horizontal screen orientation, fixes bug with time not scaling correctly on horizontal display due to previous fixed font values.