/skill-desktop-launcher

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code to work with both python2 and python3 #7

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@antlarr @forslund
@antlarr
Contributor

antlarr commented Mar 5, 2018

Additionally move the imports to the beginning of the file.

I would remove the sys.path.append code, but I didn't
want to change the behaviour.
@antlarr
Fix code to work with both python2 and python3 
Additionally move the imports to the beginning of the file.

I would remove the sys.path.append code, but I didn't
want to change the behaviour.
223936a
@forslund

This comment has been minimized.

Sign in to view
Member

forslund commented Apr 24, 2018

Sorry for the delay, This looks good.

The sys.path.append code is basically a workaround that allows the skill to work on certain machines. I personally need a different path (/usr/lib/python2.7/dist-packages/gtk-2.0) for the skill to work...there's probably a better way to do this...

@forslund forslund merged commit 08ad768 into MycroftAI:master Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment