Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check device status before/after issuing commands #11

Closed
ChristopherRogers1991 opened this issue Jun 2, 2019 · 1 comment
Closed

Check device status before/after issuing commands #11

ChristopherRogers1991 opened this issue Jun 2, 2019 · 1 comment
Labels
commonIoT Relating to the CommonIoT branch of this skill wontfix This will not be worked on

Comments

@ChristopherRogers1991
Copy link
Collaborator

As flagged in https://community.mycroft.ai/t/homeassistant-skill-misinterprets-request/6453/39, there is currently no error if you try to control a device that is offline.

This is in part due to limitations of the home assistant API, which issues an HTTP 200 (successful) response regardless of whether it was able to actual take the action issued. To resolve this, I think we'd need to query the device before (and potentially after) issuing commands, to confirm they are online, and then that the command actually worked. This would introduce some obvious race conditions, but I think in practical terms, people are unlikely to hit those.

@ChristopherRogers1991 ChristopherRogers1991 added the commonIoT Relating to the CommonIoT branch of this skill label Jun 2, 2019
@stratus-ss stratus-ss added the wontfix This will not be worked on label Dec 9, 2022
@stratus-ss
Copy link
Collaborator

i'm closing this as very stale. We aren't going to switch to the common iot framework anytime soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commonIoT Relating to the CommonIoT branch of this skill wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants