New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when saving a configuration with the Cilk Plus framework. #13

Closed
Mysticial opened this Issue Sep 13, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@Mysticial
Owner

Mysticial commented Sep 13, 2018

External bug report:

In the custom compute menu, if you change the parallel framework to Cilk Plus, the program will crash when you try to save a configuration file.

This has been fixed in both trunk and the v0.7.6 branch. It will roll out with the next patch or release. But it's not urgent since it's not computational and is "just" a minor UI bug.


Overly-detailed yet stupid explanation:

This was caused by a refactoring some versions ago that changed the behavior of some functions. This refactor was done in two phases to catch all uses of the functions and change all the call sites.

However, Cilk Plus isn't supported by the Microsoft compiler. So it's disabled (not even compiled) in the normal IDE builds through Visual Studio. Since it was disabled, it completely missed the two-phase refactor and still compiled post-refactor. The serialization code for Cilk Plus, having relied on the pre-refactor behavior of the function, would blow up post-refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment