Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Crash when saving a configuration with the Cilk Plus framework. #13
External bug report:
In the custom compute menu, if you change the parallel framework to Cilk Plus, the program will crash when you try to save a configuration file.
This has been fixed in both trunk and the v0.7.6 branch. It will roll out with the next patch or release. But it's not urgent since it's not computational and is "just" a minor UI bug.
Overly-detailed yet stupid explanation:
This was caused by a refactoring some versions ago that changed the behavior of some functions. This refactor was done in two phases to catch all uses of the functions and change all the call sites.
However, Cilk Plus isn't supported by the Microsoft compiler. So it's disabled (not even compiled) in the normal IDE builds through Visual Studio. Since it was disabled, it completely missed the two-phase refactor and still compiled post-refactor. The serialization code for Cilk Plus, having relied on the pre-refactor behavior of the function, would blow up post-refactor.