Permalink
Browse files

Fix misplaced else condition in osd.cpp. This just looks like a mista…

…ke, the else appended to the wrong block. dialog cannot be null, but Create() can and will fail. Related to Coverity defect 700311 'Logically dead code'
  • Loading branch information...
1 parent 88e9b64 commit 1207821105ba4a98cecfddc3a0d0546c3cec5681 @stuartm stuartm committed May 30, 2012
Showing with 6 additions and 6 deletions.
  1. +6 −6 mythtv/libs/libmythtv/osd.cpp
@@ -1015,12 +1015,12 @@ void OSD::DialogShow(const QString &window, const QString &text, int updatefor)
}
m_Children.insert(window, m_Dialog);
}
- }
- else
- {
- RevertUIScale();
- delete dialog;
- return;
+ else
+ {
+ RevertUIScale();
+ delete dialog;
+ return;
+ }
}
RevertUIScale();
}

0 comments on commit 1207821

Please sign in to comment.