From 1c2a6e352d2f678484faaf440b43d7cd5efc057a Mon Sep 17 00:00:00 2001 From: David Hampton Date: Wed, 27 Feb 2019 19:28:47 -0800 Subject: [PATCH] Use c++11 initialization. Use m_ for class member names. (libmythtv 2/7) Convert classes to use use the new c++11 brace initialization style. Also update class member names (when needed) so that all member names start with 'm_'. This makes it easy to distinguish class members. --- mythtv/libs/libmythtv/eitfixup.cpp | 1558 ++++++++--------- mythtv/libs/libmythtv/eithelper.cpp | 10 +- mythtv/libs/libmythtv/playgroup.h | 14 +- mythtv/libs/libmythtv/programdata.cpp | 724 ++++---- mythtv/libs/libmythtv/programdata.h | 154 +- .../test/test_eitfixups/test_eitfixups.cpp | 228 +-- .../programs/mythfilldatabase/xmltvparser.cpp | 176 +- 7 files changed, 1418 insertions(+), 1446 deletions(-) diff --git a/mythtv/libs/libmythtv/eitfixup.cpp b/mythtv/libs/libmythtv/eitfixup.cpp index 7807484ae56..4447986ebdd 100644 --- a/mythtv/libs/libmythtv/eitfixup.cpp +++ b/mythtv/libs/libmythtv/eitfixup.cpp @@ -246,137 +246,137 @@ EITFixUp::EITFixUp() void EITFixUp::Fix(DBEventEIT &event) const { - if (event.fixup) + if (event.m_fixup) { - if (event.subtitle == event.title) - event.subtitle = QString(""); + if (event.m_subtitle == event.m_title) + event.m_subtitle = QString(""); - if (event.description.isEmpty() && !event.subtitle.isEmpty()) + if (event.m_description.isEmpty() && !event.m_subtitle.isEmpty()) { - event.description = event.subtitle; - event.subtitle = QString(""); + event.m_description = event.m_subtitle; + event.m_subtitle = QString(""); } } - if (kFixHTML & event.fixup) + if (kFixHTML & event.m_fixup) FixStripHTML(event); - if (kFixHDTV & event.fixup) - event.videoProps |= VID_HDTV; + if (kFixHDTV & event.m_fixup) + event.m_videoProps |= VID_HDTV; - if (kFixBell & event.fixup) + if (kFixBell & event.m_fixup) FixBellExpressVu(event); - if (kFixDish & event.fixup) + if (kFixDish & event.m_fixup) FixBellExpressVu(event); - if (kFixUK & event.fixup) + if (kFixUK & event.m_fixup) FixUK(event); - if (kFixPBS & event.fixup) + if (kFixPBS & event.m_fixup) FixPBS(event); - if (kFixComHem & event.fixup) - FixComHem(event, kFixSubtitle & event.fixup); + if (kFixComHem & event.m_fixup) + FixComHem(event, kFixSubtitle & event.m_fixup); - if (kFixAUStar & event.fixup) + if (kFixAUStar & event.m_fixup) FixAUStar(event); - if (kFixAUDescription & event.fixup) + if (kFixAUDescription & event.m_fixup) FixAUDescription(event); - if (kFixAUFreeview & event.fixup) + if (kFixAUFreeview & event.m_fixup) FixAUFreeview(event); - if (kFixAUNine & event.fixup) + if (kFixAUNine & event.m_fixup) FixAUNine(event); - if (kFixAUSeven & event.fixup) + if (kFixAUSeven & event.m_fixup) FixAUSeven(event); - if (kFixMCA & event.fixup) + if (kFixMCA & event.m_fixup) FixMCA(event); - if (kFixRTL & event.fixup) + if (kFixRTL & event.m_fixup) FixRTL(event); - if (kFixP7S1 & event.fixup) + if (kFixP7S1 & event.m_fixup) FixPRO7(event); - if (kFixATV & event.fixup) + if (kFixATV & event.m_fixup) FixATV(event); - if (kFixDisneyChannel & event.fixup) + if (kFixDisneyChannel & event.m_fixup) FixDisneyChannel(event); - if (kFixFI & event.fixup) + if (kFixFI & event.m_fixup) FixFI(event); - if (kFixPremiere & event.fixup) + if (kFixPremiere & event.m_fixup) FixPremiere(event); - if (kFixNL & event.fixup) + if (kFixNL & event.m_fixup) FixNL(event); - if (kFixNO & event.fixup) + if (kFixNO & event.m_fixup) FixNO(event); - if (kFixNRK_DVBT & event.fixup) + if (kFixNRK_DVBT & event.m_fixup) FixNRK_DVBT(event); - if (kFixDK & event.fixup) + if (kFixDK & event.m_fixup) FixDK(event); - if (kFixCategory & event.fixup) + if (kFixCategory & event.m_fixup) FixCategory(event); - if (kFixGreekSubtitle & event.fixup) + if (kFixGreekSubtitle & event.m_fixup) FixGreekSubtitle(event); - if (kFixGreekEIT & event.fixup) + if (kFixGreekEIT & event.m_fixup) FixGreekEIT(event); - if (kFixGreekCategories & event.fixup) + if (kFixGreekCategories & event.m_fixup) FixGreekCategories(event); - if (kFixUnitymedia & event.fixup) + if (kFixUnitymedia & event.m_fixup) FixUnitymedia(event); - if (event.fixup) + if (event.m_fixup) { - if (!event.title.isEmpty()) + if (!event.m_title.isEmpty()) { - event.title = event.title.replace(QChar('\0'), ""); - event.title = event.title.trimmed(); + event.m_title = event.m_title.replace(QChar('\0'), ""); + event.m_title = event.m_title.trimmed(); } - if (!event.subtitle.isEmpty()) + if (!event.m_subtitle.isEmpty()) { - event.subtitle = event.subtitle.replace(QChar('\0'), ""); - event.subtitle = event.subtitle.trimmed(); + event.m_subtitle = event.m_subtitle.replace(QChar('\0'), ""); + event.m_subtitle = event.m_subtitle.trimmed(); } - if (!event.description.isEmpty()) + if (!event.m_description.isEmpty()) { - event.description = event.description.replace(QChar('\0'), ""); - event.description = event.description.trimmed(); + event.m_description = event.m_description.replace(QChar('\0'), ""); + event.m_description = event.m_description.trimmed(); } } - if (kFixGenericDVB & event.fixup) + if (kFixGenericDVB & event.m_fixup) { - event.programId = AddDVBEITAuthority(event.chanid, event.programId); - event.seriesId = AddDVBEITAuthority(event.chanid, event.seriesId); + event.m_programId = AddDVBEITAuthority(event.m_chanid, event.m_programId); + event.m_seriesId = AddDVBEITAuthority(event.m_chanid, event.m_seriesId); } // Are any items left unhandled? report them to allow fixups improvements - if (!event.items.empty()) + if (!event.m_items.empty()) { QMap::iterator i; - for (i = event.items.begin(); i != event.items.end(); ++i) + for (i = event.m_items.begin(); i != event.m_items.end(); ++i) { LOG(VB_EIT, LOG_DEBUG, QString("Unhandled item in EIT for" - " channel id \"%1\", \"%2\": %3").arg(event.chanid) + " channel id \"%1\", \"%2\": %3").arg(event.m_chanid) .arg(i.key()).arg(i.value())); } } @@ -430,20 +430,20 @@ void EITFixUp::FixBellExpressVu(DBEventEIT &event) const // A 0x0D character is present between the content // and the subtitle if its present - int position = event.description.indexOf(0x0D); + int position = event.m_description.indexOf(0x0D); if (position != -1) { // Subtitle present in the title, so get // it and adjust the description - event.subtitle = event.description.left(position); - event.description = event.description.right( - event.description.length() - position - 2); + event.m_subtitle = event.m_description.left(position); + event.m_description = event.m_description.right( + event.m_description.length() - position - 2); } // Take out the content description which is // always next with a period after it - position = event.description.indexOf("."); + position = event.m_description.indexOf("."); // Make sure they didn't leave it out and // you come up with an odd category if (position < 10) @@ -451,74 +451,74 @@ void EITFixUp::FixBellExpressVu(DBEventEIT &event) const } else { - event.category = "Unknown"; + event.m_category = "Unknown"; } // If the content descriptor didn't come up with anything, try parsing the category // out of the description. - if (event.category.isEmpty()) + if (event.m_category.isEmpty()) { // Take out the content description which is // always next with a period after it - position = event.description.indexOf("."); - if ((position + 1) < event.description.length()) - position = event.description.indexOf(". "); + position = event.m_description.indexOf("."); + if ((position + 1) < event.m_description.length()) + position = event.m_description.indexOf(". "); // Make sure they didn't leave it out and // you come up with an odd category if ((position > -1) && position < 20) { - const QString stmp = event.description; - event.description = stmp.right(stmp.length() - position - 2); - event.category = stmp.left(position); + const QString stmp = event.m_description; + event.m_description = stmp.right(stmp.length() - position - 2); + event.m_category = stmp.left(position); - int position_p = event.category.indexOf("("); + int position_p = event.m_category.indexOf("("); if (position_p == -1) - event.description = stmp.right(stmp.length() - position - 2); + event.m_description = stmp.right(stmp.length() - position - 2); else - event.category = "Unknown"; + event.m_category = "Unknown"; } else { - event.category = "Unknown"; + event.m_category = "Unknown"; } // When a channel is off air the category is "-" // so leave the category as blank - if (event.category == "-") - event.category = "OffAir"; + if (event.m_category == "-") + event.m_category = "OffAir"; - if (event.category.length() > 20) - event.category = "Unknown"; + if (event.m_category.length() > 20) + event.m_category = "Unknown"; } - else if (event.categoryType) + else if (event.m_categoryType) { - QString theme = dish_theme_type_to_string(event.categoryType); - event.description = event.description.replace(theme, ""); - if (event.description.startsWith(".")) - event.description = event.description.right(event.description.length() - 1); - if (event.description.startsWith(" ")) - event.description = event.description.right(event.description.length() - 1); + QString theme = dish_theme_type_to_string(event.m_categoryType); + event.m_description = event.m_description.replace(theme, ""); + if (event.m_description.startsWith(".")) + event.m_description = event.m_description.right(event.m_description.length() - 1); + if (event.m_description.startsWith(" ")) + event.m_description = event.m_description.right(event.m_description.length() - 1); } // See if a year is present as (xxxx) - position = event.description.indexOf(m_bellYear); - if (position != -1 && !event.category.isEmpty()) + position = event.m_description.indexOf(m_bellYear); + if (position != -1 && !event.m_category.isEmpty()) { tmp = ""; // Parse out the year bool ok; - uint y = event.description.mid(position + 1, 4).toUInt(&ok); + uint y = event.m_description.mid(position + 1, 4).toUInt(&ok); if (ok) { - event.originalairdate = QDate(y, 1, 1); - event.airdate = y; - event.previouslyshown = true; + event.m_originalairdate = QDate(y, 1, 1); + event.m_airdate = y; + event.m_previouslyshown = true; } // Get the actors if they exist if (position > 3) { - tmp = event.description.left(position-3); + tmp = event.m_description.left(position-3); QStringList actors = tmp.split(m_bellActors, QString::SkipEmptyParts); QStringList::const_iterator it = actors.begin(); @@ -526,180 +526,180 @@ void EITFixUp::FixBellExpressVu(DBEventEIT &event) const event.AddPerson(DBPerson::kActor, *it); } // Remove the year and actors from the description - event.description = event.description.right( - event.description.length() - position - 7); + event.m_description = event.m_description.right( + event.m_description.length() - position - 7); } // Check for (CC) in the decription and // set the flag - position = event.description.indexOf("(CC)"); + position = event.m_description.indexOf("(CC)"); if (position != -1) { - event.subtitleType |= SUB_HARDHEAR; - event.description = event.description.replace("(CC)", ""); + event.m_subtitleType |= SUB_HARDHEAR; + event.m_description = event.m_description.replace("(CC)", ""); } // Check for (Stereo) in the decription and set the