Permalink
Browse files

Initialize the MythUIImage filename correctly

Fixes #9634.  Fixes #9708.  Refs #9547.

If the filename does not start with "/", "http://", "https://" or "ftp://", then
the actual filename loaded is uninitialized.  It can be any random crap on the
stack.  I'm honestly surprised this worked at all :)

This may fix things for #9547 as well, and should be tested with that
scenario too.
  • Loading branch information...
1 parent 62d7084 commit 2c7735e7f80b5d2737d2bc8c4e9144f3e42da2e7 @Beirdo Beirdo committed May 28, 2011
Showing with 1 addition and 1 deletion.
  1. +1 −1 mythtv/libs/libmythui/mythuiimage.cpp
@@ -85,7 +85,7 @@ class ImageLoadThread : public QRunnable
void run()
{
- QString tmpFilename;
+ QString tmpFilename = m_filename;
if ((m_filename.startsWith("/")) ||
(m_filename.startsWith("http://")) ||
(m_filename.startsWith("https://")) ||

0 comments on commit 2c7735e

Please sign in to comment.