Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Metadata Lookup: Prevent lookups for items which already have metadata.
Multiple people attempted to fix the "null insert" issue with inetref
(among other "NOT NULL" fields) but all the fixes were left in-- including
initializing the inetref to an empty string even when one already existed
in the programinfo-- this led to a regression where everything was being
looked up, every time, because even if there was an inetref, it would
always be replaced with an empty string.
  • Loading branch information
Robert McNamara committed Oct 8, 2011
1 parent 1b66c04 commit 4614384
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/recordingrule.cpp
Expand Up @@ -27,7 +27,7 @@ RecordingRule::RecordingRule()
m_startdate(QDate::currentDate()),
m_endtime(QTime::currentTime()),
m_enddate(QDate::currentDate()),
m_inetref(""), // String could be null when we trying to insert into DB
m_inetref(), // String could be null when we trying to insert into DB
m_channelid(0),
m_findday(-1),
m_findtime(QTime::fromString("00:00:00", Qt::ISODate)),
Expand Down Expand Up @@ -608,7 +608,7 @@ void RecordingRule::AssignProgramInfo()
}
}
m_category = m_progInfo->GetCategory();
m_inetref = "";
m_inetref = m_progInfo->GetInetRef();
}

unsigned RecordingRule::GetDefaultFilter(void)
Expand Down

0 comments on commit 4614384

Please sign in to comment.