From 473130bbfded09be2ea4811e7eb2203fa885da75 Mon Sep 17 00:00:00 2001 From: Jean-Yves Avenard Date: Sat, 22 Jun 2013 01:47:46 +1000 Subject: [PATCH] Fix coverity report One false positive: Coverity-Id: 1023902. default constructor would have taken care of it. One real one: Coverity-Id: 1023901; in operator= ; we weren't copying the AES IV from the copied HLSStream --- mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp b/mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp index ae70d341195..e718847660e 100644 --- a/mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp +++ b/mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp @@ -394,6 +394,7 @@ class HLSStream m_url = uri; #ifdef USING_LIBCRYPTO m_ivloaded = false; + memset(m_AESIV, 0, sizeof(m_AESIV)); #endif } @@ -439,6 +440,7 @@ class HLSStream #ifdef USING_LIBCRYPTO m_keypath = rhs.m_keypath; m_ivloaded = rhs.m_ivloaded; + memcpy(m_AESIV, rhs.m_AESIV, sizeof(m_AESIV)); #endif return *this; }