From 574973eef0dbedf579b4441dccd111ad33078f01 Mon Sep 17 00:00:00 2001 From: Paul Harrison Date: Wed, 12 Jun 2013 16:56:00 +0100 Subject: [PATCH] VideoDialog: fix coverity ID 746884 Uninitialized pointer field In VideoDialog::VideoDialog(): Several pointer fields are not initialized in the constructor. --- mythtv/programs/mythfrontend/videodlg.cpp | 39 +++++++++++++++-------- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/mythtv/programs/mythfrontend/videodlg.cpp b/mythtv/programs/mythfrontend/videodlg.cpp index eff273d666e..dc62782e183 100644 --- a/mythtv/programs/mythfrontend/videodlg.cpp +++ b/mythtv/programs/mythfrontend/videodlg.cpp @@ -835,27 +835,38 @@ VideoDialog::VideoListDeathDelayPtr &VideoDialog::GetSavedVideoList() } VideoDialog::VideoDialog(MythScreenStack *lparent, QString lname, - VideoListPtr video_list, DialogType type, BrowseType browse) : - MythScreenType(lparent, lname), m_menuPopup(0), m_busyPopup(0), - m_videoButtonList(0), m_videoButtonTree(0), m_titleText(0), - m_novideoText(0), m_positionText(0), m_crumbText(0), m_coverImage(0), - m_screenshot(0), m_banner(0), m_fanart(0), m_trailerState(0), - m_parentalLevelState(0), m_watchedState(0), m_studioState(0) + VideoListPtr video_list, DialogType type, BrowseType browse) + : MythScreenType(lparent, lname), + m_menuPopup(NULL), + m_busyPopup(NULL), + m_popupStack(GetMythMainWindow()->GetStack("popup stack")), + m_mainStack(GetMythMainWindow()->GetMainStack()), + m_videoButtonList(NULL), + m_videoButtonTree(NULL), + m_titleText(NULL), + m_novideoText(NULL), + m_positionText(NULL), + m_crumbText(NULL), + m_coverImage(NULL), + m_screenshot(NULL), + m_banner(NULL), + m_fanart(NULL), + m_trailerState(NULL), + m_parentalLevelState(NULL), + m_videoLevelState(NULL), + m_userRatingState(NULL), + m_watchedState(NULL), + m_studioState(NULL), + m_metadataFactory(new MetadataFactory(this)), + m_d(new VideoDialogPrivate(video_list, type, browse)) { - m_metadataFactory = new MetadataFactory(this); - - m_d = new VideoDialogPrivate(video_list, type, browse); - - m_popupStack = GetMythMainWindow()->GetStack("popup stack"); - m_mainStack = GetMythMainWindow()->GetMainStack(); - m_d->m_videoList->setCurrentVideoFilter(VideoFilterSettings(true, lname)); m_d->m_parentalLevel.SetLevel(ParentalLevel(gCoreContext-> GetNumSetting("VideoDefaultParentalLevel", ParentalLevel::plLowest))); - + StorageGroup::ClearGroupToUseCache(); }