From 581730997f7a7cd55e106b7b1a16ff3921bf35a4 Mon Sep 17 00:00:00 2001 From: Paul Harrison Date: Mon, 3 Jun 2013 20:40:47 +0100 Subject: [PATCH] FileScanner: fix Coverity ID 1026724 Dereference before null check Move some code to after the NULL check. --- mythplugins/mythmusic/mythmusic/filescanner.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mythplugins/mythmusic/mythmusic/filescanner.cpp b/mythplugins/mythmusic/mythmusic/filescanner.cpp index 7a138a73fe6..d1eaa37cff7 100644 --- a/mythplugins/mythmusic/mythmusic/filescanner.cpp +++ b/mythplugins/mythmusic/mythmusic/filescanner.cpp @@ -260,9 +260,10 @@ void FileScanner::AddFileToDB(const QString &filename) LOG(VB_FILE, LOG_INFO, QString("Reading metadata from %1").arg(filename)); MusicMetadata *data = MetaIO::readMetadata(filename); - data->setFileSize((quint64)QFileInfo(filename).size()); if (data) { + data->setFileSize((quint64)QFileInfo(filename).size()); + QString album_cache_string; // Set values from cache