Browse files

backport 0026dda

fix issue #10222: mythcommflag segfaulting

The problem in issue #10222 is that it is adding the CODEC_FLAG2_FAST flag.
This causes unsafe functions to be used, causing a segfault. The proper way to
fix this would probably be to figure out how to test for the "experimental
speedups" flag, however I don't know the codebase well enough for this.

I tested how this would affect the speed of mythcommflag on one of my recordings.
The results:

Before removing flag:
real 2m13.123s
user 2m16.713s
sys 0m3.502s

After removing flag:
real 2m13.021s
user 2m15.446s
sys 0m3.758s

Signed-off-by: Taylor Ralph <>
  • Loading branch information...
thomas-joiner authored and tralph committed Mar 1, 2013
1 parent 0f6b764 commit 947bb60fa9f3a7e7fd0c5d4300df1cdb9b3d4745
Showing with 0 additions and 2 deletions.
  1. +0 −2 mythtv/libs/libmythtv/avformatdecoder.cpp
@@ -1327,8 +1327,6 @@ void AvFormatDecoder::InitVideoCodec(AVStream *stream, AVCodecContext *enc,
FlagIsSet(kDecodeFewBlocks) || FlagIsSet(kDecodeNoLoopFilter) ||
- enc->flags2 |= CODEC_FLAG2_FAST;
if ((CODEC_ID_MPEG2VIDEO == codec->id) ||
(CODEC_ID_MPEG1VIDEO == codec->id))

0 comments on commit 947bb60

Please sign in to comment.