From 9a0e0dd75836b728d8daebe192a59b78df9e244f Mon Sep 17 00:00:00 2001 From: David Hampton Date: Mon, 1 Nov 2021 13:11:49 -0400 Subject: [PATCH] tidy: Modernize a couple of "display" loops. Convert these loops to the "new" c++11 range-based loops. https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html --- mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp | 4 ++-- mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp | 4 ++-- mythtv/libs/libmythui/platforms/mythdisplayx11.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp b/mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp index 31c95f85179..99b07995775 100644 --- a/mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp +++ b/mythtv/libs/libmythui/platforms/mythdisplaydrm.cpp @@ -153,8 +153,8 @@ const MythDisplayModes& MythDisplayDRM::GetVideoModes() m_modeMap.insert(MythDisplayMode::CalcKey(resolution, rate), mode->m_index); } - for (auto it = screenmap.begin(); screenmap.end() != it; ++it) - m_videoModes.push_back(it->second); + for (auto & it : screenmap) + m_videoModes.push_back(it.second); DebugModes(); return m_videoModes; diff --git a/mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp b/mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp index 7ca1e363f3b..9d8cbe80dd5 100644 --- a/mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp +++ b/mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp @@ -334,8 +334,8 @@ const MythDisplayModes& MythDisplayMutter::GetVideoModes() m_modeMap.insert(MythDisplayMode::CalcKey(resolution, rate), mmode.id); } - for (auto it = screenmap.begin(); screenmap.end() != it; ++it) - m_videoModes.push_back(it->second); + for (auto & it : screenmap) + m_videoModes.push_back(it.second); DebugModes(); return m_videoModes; diff --git a/mythtv/libs/libmythui/platforms/mythdisplayx11.cpp b/mythtv/libs/libmythui/platforms/mythdisplayx11.cpp index 503ac6a768d..d20b9bfdd13 100644 --- a/mythtv/libs/libmythui/platforms/mythdisplayx11.cpp +++ b/mythtv/libs/libmythui/platforms/mythdisplayx11.cpp @@ -165,8 +165,8 @@ const MythDisplayModes& MythDisplayX11::GetVideoModes() } } - for (auto it = screenmap.begin(); screenmap.end() != it; ++it) - m_videoModes.push_back(it->second); + for (auto & it : screenmap) + m_videoModes.push_back(it.second); DebugModes(); XRRFreeOutputInfo(output);