From a825deedcf380d76a7447bc3ebd00272eff5be89 Mon Sep 17 00:00:00 2001
From: Daniel Kristjansson <danielk@cuymedia.net>
Date: Tue, 11 Sep 2012 11:46:33 -0400
Subject: [PATCH] Avoid unnecessary QString copy. (cppcheck)

---
 mythtv/libs/libmythbase/mythsystem.h       | 2 +-
 mythtv/libs/libmythbase/system-unix.cpp    | 2 +-
 mythtv/libs/libmythbase/system-unix.h      | 2 +-
 mythtv/libs/libmythbase/system-windows.cpp | 3 +--
 mythtv/libs/libmythbase/system-windows.h   | 2 +-
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/mythtv/libs/libmythbase/mythsystem.h b/mythtv/libs/libmythbase/mythsystem.h
index 69836fd7871..ea874acc5b5 100644
--- a/mythtv/libs/libmythbase/mythsystem.h
+++ b/mythtv/libs/libmythbase/mythsystem.h
@@ -152,7 +152,7 @@ class MBASE_PUBLIC MythSystemPrivate : public QObject, public ReferenceCounter
         virtual void Signal(int sig) = 0;
         virtual void JumpAbort(void) = 0;
 
-        virtual bool ParseShell(const QString cmd, QString &abscmd,
+        virtual bool ParseShell(const QString &cmd, QString &abscmd,
                                 QStringList &args) = 0;
 
     protected:
diff --git a/mythtv/libs/libmythbase/system-unix.cpp b/mythtv/libs/libmythbase/system-unix.cpp
index eb713d71895..86a6cf4ac08 100644
--- a/mythtv/libs/libmythbase/system-unix.cpp
+++ b/mythtv/libs/libmythbase/system-unix.cpp
@@ -588,7 +588,7 @@ MythSystemUnix::~MythSystemUnix(void)
 {
 }
 
-bool MythSystemUnix::ParseShell(const QString cmd, QString &abscmd,
+bool MythSystemUnix::ParseShell(const QString &cmd, QString &abscmd,
                                 QStringList &args)
 {
     QList<QChar> whitespace; whitespace << ' ' << '\t' << '\n' << '\r';
diff --git a/mythtv/libs/libmythbase/system-unix.h b/mythtv/libs/libmythbase/system-unix.h
index c7436bd645d..f49071a35d5 100644
--- a/mythtv/libs/libmythbase/system-unix.h
+++ b/mythtv/libs/libmythbase/system-unix.h
@@ -91,7 +91,7 @@ class MBASE_PUBLIC MythSystemUnix : public MythSystemPrivate
         virtual void Signal(int sig);
         virtual void JumpAbort(void);
 
-        virtual bool ParseShell(const QString cmd, QString &abscmd,
+        virtual bool ParseShell(const QString &cmd, QString &abscmd,
                                 QStringList &args);
 
         friend class MythSystemManager;
diff --git a/mythtv/libs/libmythbase/system-windows.cpp b/mythtv/libs/libmythbase/system-windows.cpp
index 64adb5b9998..2ff09a65cf8 100644
--- a/mythtv/libs/libmythbase/system-windows.cpp
+++ b/mythtv/libs/libmythbase/system-windows.cpp
@@ -543,8 +543,7 @@ MythSystemWindows::~MythSystemWindows(void)
 {
 }
 
-bool MythSystemWindows::ParseShell(const QString cmd, QString &abscmd,
-                                   QStringList &args)
+bool MythSystemWindows::ParseShell(const QString&, QString &, QStringList&)
 {
     return false;
 }
diff --git a/mythtv/libs/libmythbase/system-windows.h b/mythtv/libs/libmythbase/system-windows.h
index dbf1a71f604..fa9ead5184f 100644
--- a/mythtv/libs/libmythbase/system-windows.h
+++ b/mythtv/libs/libmythbase/system-windows.h
@@ -90,7 +90,7 @@ class MBASE_PUBLIC MythSystemWindows : public MythSystemPrivate
         virtual void Signal(int sig);
         virtual void JumpAbort(void);
 
-        virtual bool ParseShell(const QString cmd, QString &abscmd,
+        virtual bool ParseShell(const QString &cmd, QString &abscmd,
                                 QStringList &args);
 
         friend class MythSystemManager;