Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fix MythPlayer::GetRawVideoFrame() for mythcommflag.

Fix MythPlayer::GetRawVideoFrame() to return the correct frame number.
This change fixes mythcommflag so that it will return consistent results
across multiple runs.  It should also improve commercial detection
accuracy, as the frame numbers identified by the different methods will
actually be precise--allowing for better comparing the results of the
different methods.

Although this commit has my name for the signed-off line, I didn't do
much.  Thanks to Kevin Ross for the debugging and the patch, to Taylor
Ralph and Mark Kendall for actually reviewing the patch, and to all the
users and devs who ran with the patch to test it (and saw
greatly-improved commercial flagging results).

Fixes #9997.

Signed-off-by: Michael T. Dean <>
(cherry picked from commit f135d5d)
  • Loading branch information...
1 parent a24ecbf commit cb01f3079a0eadf430178fefd5c2341235152fd1 @k-ross k-ross committed with sphery
Showing with 2 additions and 1 deletion.
  1. +2 −1  mythtv/libs/libmythtv/mythplayer.cpp
3  mythtv/libs/libmythtv/mythplayer.cpp
@@ -4089,7 +4089,8 @@ VideoFrame* MythPlayer::GetRawVideoFrame(long long frameNumber)
VERBOSE(VB_PLAYBACK, LOC + QString("Waited 100ms for video frame"));
- return videoOutput->GetLastDecodedFrame();
+ videoOutput->StartDisplayingFrame();
+ return videoOutput->GetLastShownFrame();
QString MythPlayer::GetEncodingType(void) const

0 comments on commit cb01f30

Please sign in to comment.
Something went wrong with that request. Please try again.