Permalink
Browse files

Fix potential derefernce after NULL check in AudioConfigSettings.

I actually can't see how m_MaxAudioChannels, m_AudioUpmix or
m_AudioUpmixType could ever be NULL, but I think this changee is what
the original author intended.  Fixes Coverity 700422.
  • Loading branch information...
gigem committed Jun 19, 2013
1 parent 2338de1 commit cfd2ee84c469048403ea545ce331cb4471489ced
Showing with 1 addition and 1 deletion.
  1. +1 −1 mythtv/programs/mythfrontend/audiogeneralsettings.cpp
@@ -242,7 +242,7 @@ void AudioConfigSettings::AudioRescan()
void AudioConfigSettings::UpdateVisibility(const QString &device)
{
if (!m_MaxAudioChannels && !m_AudioUpmix && !m_AudioUpmixType)
if (!m_MaxAudioChannels || !m_AudioUpmix || !m_AudioUpmixType)
return;
int cur_speakers = m_MaxAudioChannels->getValue().toInt();

0 comments on commit cfd2ee8

Please sign in to comment.