From d21f82622c046a8573c6f5604ce64b653bc184c8 Mon Sep 17 00:00:00 2001 From: David Hampton Date: Mon, 2 Oct 2023 11:59:48 -0400 Subject: [PATCH] tidy: Fix a couple of potential memory leaks in testing code. Replace manual memory management with a c++ unique pointer. https://clang.llvm.org/docs/analyzer/checkers.html#cplusplus-newdeleteleaks --- .../test_recordingextender/test_recordingextender.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/mythtv/programs/mythbackend/test/test_recordingextender/test_recordingextender.cpp b/mythtv/programs/mythbackend/test/test_recordingextender/test_recordingextender.cpp index 2c6ea30de2f..20edd2f5c35 100644 --- a/mythtv/programs/mythbackend/test/test_recordingextender/test_recordingextender.cpp +++ b/mythtv/programs/mythbackend/test/test_recordingextender/test_recordingextender.cpp @@ -564,7 +564,7 @@ void TestRecordingExtender::test_parseProgramInfo(void) void TestRecordingExtender::test_parseJson(void) { m_nowForTest = QDateTime::fromString("2021-09-22T23:59:00Z", Qt::ISODate); - auto* source = new TestRecExtMlbDataSource(this); + auto source = std::make_unique(this); SportInfo info {"MLB Baseball", AutoExtendType::MLB, "", ""}; ActiveGame game(0, "MLB Baseball", info); @@ -689,7 +689,7 @@ void TestRecordingExtender::test_parseEspn(void) QFETCH(QString, expectedTextState); m_nowForTest = QDateTime::fromString(nowForTest, Qt::ISODate); - auto* source = new TestRecExtEspnDataSource(this); + auto source = std::make_unique(this); SportInfo info {"MLB Baseball", AutoExtendType::ESPN, sport, league}; ActiveGame game(0, "MLB Baseball", info); @@ -731,8 +731,6 @@ void TestRecordingExtender::test_parseEspn(void) QCOMPARE(gameState.getPeriod(), expectedPeriod); QCOMPARE(gameState.isFinished(), expectedFinished); QCOMPARE(gameState.getTextState(), expectedTextState); - - delete source; } void TestRecordingExtender::test_parseMlb_data(void) @@ -788,7 +786,7 @@ void TestRecordingExtender::test_parseMlb(void) QFETCH(QString, expectedTextState); m_nowForTest = QDateTime::fromString(nowForTest, Qt::ISODate); - auto* source = new TestRecExtMlbDataSource(this); + auto source = std::make_unique(this); SportInfo info {"MLB Baseball", AutoExtendType::MLB, "sport", "league"}; ActiveGame game(0, "MLB Baseball", info); @@ -832,8 +830,6 @@ void TestRecordingExtender::test_parseMlb(void) QCOMPARE(gameState.getPeriod(), expectedPeriod); QCOMPARE(gameState.isFinished(), expectedFinished); QCOMPARE(gameState.getTextState(), expectedTextState); - - delete source; } void TestRecordingExtender::test_processNewRecordings_data(void)