Permalink
Browse files

Always re-encode to best supported format.

This change was originally added to prevent audio buffer overruns, but we have now fix this other bug.. So let's keep focusing on quality
  • Loading branch information...
1 parent 83e43f3 commit df80fc55bc477514a5f2465342b663e1a69c8a53 @jyavenard jyavenard committed Dec 14, 2010
Showing with 1 addition and 12 deletions.
  1. +1 −12 mythtv/libs/libmyth/audio/audiooutputbase.cpp
@@ -579,18 +579,7 @@ void AudioOutputBase::Reconfigure(const AudioSettings &orig_settings)
if (enc)
output_format = FORMAT_S16; // Output s16le for AC-3 encoder
else
- {
- // re-encode audio using same format as input if upmixing
- // to minimize the memory sound buffer usage. There should be
- // no siginificant quality loss
- if (needs_upmix &&
- output_settings->IsSupportedFormat(format))
- {
- output_format = format;
- }
- else
- output_format = output_settings->BestSupportedFormat();
- }
+ output_format = output_settings->BestSupportedFormat();
}
bytes_per_frame = processing ? 4 : output_settings->SampleSize(format);

0 comments on commit df80fc5

Please sign in to comment.