I would say it is surprising for a user of that API function that the content of the passed string is changed/moved here. Seems like a strange thing t me. Just my two cents. :-)