Permalink
Commits on Oct 16, 2017
  1. Use short input name instead of sgroupid in some Scheduler output.

    gigem committed Oct 16, 2017
    The schedule group ID isn't passed over the wire, so some output, like
    from mythbackend --printsched would print useless zeros.  Also, clear
    the input name when a program isn't going to be recorded.  This is
    similar to how the other input information is already cleared.
Commits on Oct 13, 2017
Commits on Oct 12, 2017
  1. Fix documentation for QUERY_FILE_EXISTS protocol message.

    linuxdude42 committed Oct 12, 2017
    The message name needs to be on the same line as the doxygen
    "paragraph" commands so that it show up in the myth_network_protocol
    group.
  2. Merge the 'devel/dh/doccleanup' branch into master.

    linuxdude42 committed Oct 12, 2017
    The majority of these changes are to the documentation itself, either
    adding documentation or correcting nits that throw off the doxygen
    parser.  There are a couple of places where variable names were
    changed to match up declaration and definition and code.  This patch
    also adds semicolons after a number of macro calls.  While not needed
    by the compiler, the lack of a semicolon completely throws off the
    doxygen parser.  Upgrade the doxygen configuration file to the latest
    version.  Fixes #13107.
  3. Change the mask on the exit message from MythUIHelper::PruneCacheDir.

    linuxdude42 committed Oct 12, 2017
    This function has an entry message that is printed when general
    debugging is requested.  Change the exit message to use the same
    criteria for printing.
Commits on Oct 11, 2017
  1. Make the Canadian weather scripts work again.

    linuxdude42 committed Sep 7, 2017
    Fix the parsing code that is looking for the letter 'C' in the
    temperature and dew-point lines.  This was unnecessarily escaped as
    '\C' which causes Perl to complain about a no longer supported regex.
    Removing the escaping solves the problem.
    
    github: closes #152
    trac: fixes #13118
Commits on Oct 10, 2017
  1. Create all directories leading to the ttvdb/tmdb3 cache files.

    linuxdude42 committed Sep 22, 2017
    With this change, MythTv will create all directories leading up to the
    cache file, instead of only creating the final directory.  This will
    solve some recent problems on the mailing list where the ttvdb/tmdb3
    scripts would work in some scenarios and fail in others.
    
    Trac: fixes #13128
    GitHub: closes #154
  2. Parse subclass specific tags before calling base class parser.

    linuxdude42 committed Oct 10, 2017
    Modify the code to parse the subclass tags first, and only call the
    base class parser on unrecognized tags.  This prevents the base class
    parser from complaining about all subclass tags.  Moving the call to
    the base function exposes the problem that both the base class and the
    subclass are coded to match the "font" tag.  Remove the subclass match
    as the parser in the base class is the correct parser for that tag
    (and the subclass match has never happened since the base class always
    returns true for the "font" tag preventing the subclass match.)
  3. Re-enable warning messages from MythUIType::ParseElement.

    linuxdude42 committed Oct 10, 2017
    Also change the wording of the message to match that used in
    xmlparsebase.cpp.
  4. Settings: Improved Video Playback Profile setup

    bennettpeter committed Oct 10, 2017
    Simplify the setup and checking of video size in selection of
    playback profile.
    
    Fixes #13133
Commits on Oct 9, 2017
  1. Cleanup gcc and clang warnings generated by -Wextra switch.

    linuxdude42 committed Oct 9, 2017
    This commit fixes a large majority of the warnings generated by using
    the -Wextra switch to gcc and clang.  It does not fix any warning
    related to objects that use QObject as their base class.  Enabling the
    -Wextra flag by default will occur in a later commit.
    
    Trac: fixes #12996
    Github: fixes #134
  2. Use local variable to prevent warning messages.

    linuxdude42 committed Aug 17, 2017
    The compiler was throwing a warning messages because the only uses of
    the nFlags were conditionally compiled out. There are two other places
    in this function that could use this local variable (instead of
    re-reading the source variable) so update them.  This will eliminate
    the warning message.
  3. Conditionally compile out unfinished code.

    linuxdude42 committed Aug 5, 2017
    The PlaybackBoxListItem class was created in 2009 by commit 4004eda
    but was never fleshed out.  Put the unfinished code behind an #ifdef
    to eliminate compiler warnings for unused variables.
  4. Fix 'address of array will always evaluate to true' warning.

    linuxdude42 committed Aug 4, 2017
    This appears to be a test to check whether both 1) a buffer has been
    allocated and 2) the buffer contains data.  However, in this
    particular case the data structure embeds the actual buffer (instead
    of a pointer to a buffer) so that the first test is unnecessary. If
    you have a structure, you have the embedded buffer.  Remove the test
    to eliminate the compiler warning.
  5. Fix "using directive refers to implicitly-defined namespace 'std'" wa…

    linuxdude42 committed Aug 4, 2017
    …rning.
    
    Its apparently unnecessary to explicitly include the 'std' namespace,
    and now causes a compiler warning message.  Remove the include to
    eliminate the warning.
  6. Fix 'comparison of integers of different signs' warning message.

    linuxdude42 committed Aug 4, 2017
    The 'rep' field in the lirc_state structure is unsigned, so convert
    the parsing of that value to also use an unsigned variable.  In
    lirc_read_string, use a size_t for the head and tail variables since
    they're offsets into a buffer and are being compared to the result of
    strlen(). In lirc_send_command, 'n' and 'data_n' should be the same
    type.
  7. Fix 'max of value and unsigned zero' warning message.

    linuxdude42 committed Aug 4, 2017
    The iterator in all of these functions is iterating over a structure
    that contains two unsigned values, and is returning one of them.  It
    is a truism that taking the max of an unsigned value and zero will
    always return the unsigned value, therefore the call to max() is
    superfluous.
  8. Fix 'implicit conversion changes value' warning message.

    linuxdude42 committed Aug 4, 2017
    This is an old problem of using signed character strings to hold
    binary network data.  The network channel is 8-bit, but because the
    string isn't declared as unsigned the compiler complains about the use
    of the most significant bit.  Fix this warning by declaring the buffer
    as holding unsigned characters, and then cast the call to the
    writeDatagram function.  In an ideal world, the writeDatagram function
    would take an uchar* argument, but at some point there will have to be
    a cast to a char* as that's what the underlying QUdpSocket function
    expects.
  9. Conditionally compile out the unused RequestRange function.

    linuxdude42 committed Aug 2, 2017
    The clang compiler complains about an unused inline function for
    requesting a specific range of bytes from a web document.  This seems
    like a function that might be useful to have in the code in the
    future, so conditionally compile it out instead of deleting it.
  10. Move an unused InfoMap printing function to a different file.

    linuxdude42 committed Aug 2, 2017
    The clang compiler complains about an unused inline function for
    printing out the contents of an InfoMap structure.  This seems like a
    useful function to have in the code that could be reused elsewhere.
    Move it from its current location to the file that defines the InfoMap
    structure and take off the inline keyword (which eliminates the
    compiler complaint).
  11. Flag unused variables as used in C code.

    linuxdude42 committed Aug 1, 2017
    Unused variable warnings in C code can't be eliminated by commenting
    out the variable name in the function declaration. (That results in an
    error instead of a warning.)  Add instances of "(void) x" to the code
    to eliminate the compiler warnings from clang.
  12. Fix logic error in error handling in httptsstreamhandler.cpp.

    linuxdude42 committed Jul 28, 2017
    The existing code reads awkwardly, gets the right results for the
    wrong reason, and causes a compiler error when using clang.  Replace
    it with equivalent code that is easier to read and parse.
  13. Fix conditionally used member variables in the VideoOutputOMX class.

    linuxdude42 committed Aug 2, 2017
    There are three member variable that are unconditionally defined and
    initialized, but then only used if the string OSD_EGL is defined.
    This causes clang to emit a warning error about private fields not
    being used.  Move the declaration and initialization of these three
    variables behind #ifdef statements to eliminate the compiler warnings
    from clang.
  14. Remove unused member variables from the ChannelGroupSetting class.

    linuxdude42 committed Aug 1, 2017
    The last reference to the m_markForDeletion member variable was
    removed in 2017 by commit 420a1ea.  Remove the variable to eliminate
    a compiler warning from clang.
  15. Remove never used member variables from two classes.

    linuxdude42 committed Aug 1, 2017
    The GuideUpdateProgramRow and GuideStatus classes have never used
    their m_channelInfos_size variables since the code was first added
    2013 by commit 7f2140c.  Remove the two variables to eliminate
    compiler warnings from clang.
  16. Remove never used member variable from the GameScannerThread class.

    linuxdude42 committed Aug 1, 2017
    The m_parent variable has never been used by the GameScannerThread
    class since the class was introduced in 2011 by commit a160548.
    Remove the variable to eliminate a compiler warning from clang.
  17. Remove unused private member variable from the PlaylistContainer class.

    linuxdude42 committed Aug 1, 2017
    The last reference to the m_allMusic member variable (then named
    all_available_music) was removed in 2012 by commit 8e29824.  Remove
    the variable to eliminate a compiler warning from clang.
  18. Remove never used private member variable from the Squares class.

    linuxdude42 committed Aug 1, 2017
    The pParent private member variable has never been used since its
    introduction in 2006 in commit 6407448.  Remove it to eliminate a
    compiler warning from clang.
  19. Remove four unused private variables from the ClassicLogoDetector class.

    linuxdude42 committed Jul 28, 2017
    Three of the variables have been unused since 2006 when the classic
    logo detector was split out from the scene change detector (commit
    dfc44fa).  The forth was referenced by an unused function, until that
    function was removed in 2015 by commit 06d3f82.  Remove all four
    variables to eliminate compiler warnings from clang.
  20. Comment out an unused constant from BBCi streams support.

    linuxdude42 committed Jul 28, 2017
    This constant has never been used since the code was introduced in
    2010 by 4d5e6ca.  Comment it out to eliminate a compiler warning from
    clang.  Fix up a comment while in the file.