Permalink
Commits on Aug 8, 2013
  1. Fix a couple potential segfaults in MythDownloadManager.

    cpinkham committed Aug 8, 2013
    In both GetLastModified() and download(QString,bool), we were
    deleting the MythDownloadInfo* even when downloadNow() failed.  Whenever
    downloadNow() fails, it sets a flag to allow downloadFinished() to
    clean up as if the call was async instead of sync, so we only need to
    delete our MythDownloadInfo* if the download succeeded.
Commits on Aug 3, 2013
Commits on Jun 25, 2013
  1. Add a --clearseektable option to mythutil.

    cpinkham committed Jun 25, 2013
    This will delete any existing seek table out of the DB.  It does
    not remove any other markup items such as duration.
  2. Channel Icon fixes

    cpinkham committed Jun 25, 2013
    - Store Channel Icon filenames in the DB without directory info.  This change
      affects both mythfilldatabase and mythtv-setup.
    
      Fixes #10659.
    
    - Fix a channel icon editor refresh issue where the newly downloaded icon
      would not be displayed in the buttonlist if the icon was downloaded
      automatically without the user having to select an icon from the list.
Commits on Jun 24, 2013
  1. Consistency with mythtv/.gitignore

    cpinkham committed Jun 24, 2013
    Instead of explicitly listing config.ep, .log, .pro, just use
    config.* as we do in .gitignore so they're consistent.
  2. RemoteFile leak fix and simplification

    cpinkham committed Jun 24, 2013
    RemoteFile::Open() would leak file descriptors if Open() was explicitly
    called again after passing a url to the contructor which itself called
    Open().
    
    This commit does several things:
    
    - Moves Open() private since RemoteFile users shouldn't need to Open()
    - Moves Close() private since there's no need to Close() if you can't Open().
      Close() is already called in the destructor.
    - Convert the remaining uses of Open() to isOpen() since the connection is
      already opened in all these cases.
    - Remove a few Close() uses since they were were redundant since we already
      Close() in the destructor.
    - Removes unused SetURL() functionality.  If you can't Open() or Close(),
      then you need to pass the URL in to the constructor so there's no need.
    - Fixes the actual leak in Open() by checking to see if the sockets are
      already open.  Just in case....  Closes #11341.
    
    NOTE: This does modify the binary ABI version number due to the remotefile.h
          changes, so make clean, etc..
  3. Fix transcoding to high resolutions.

    cpinkham committed Jun 24, 2013
    When the transcoder loaded the recording profile, the max width and
    height fields were not being set properly so transcoding profiles
    with high resolutions were instead limited to 768x576.  Since these
    max values are set the ImageSize ctor, changing them after the fact
    is a bit invasive.  Rather than using a RecordingProfile variable
    in Transcode and trying to change the values after the fact, this patch
    fixes the issue by using a RecordingProfile pointer and creating an
    instance allowing us to tell the constructor that the profile we're
    going to load is a transcoder profile and the max resolution values
    (and any other transcoder-specific values or limits) should be
    set correctly.
    
    Fixes #11348.
Commits on Jun 21, 2013
Commits on Jun 15, 2013
  1. Add a --download option to mythutil.

    cpinkham committed Jun 15, 2013
    "--download --infile URI --outfile FILENAME" will download the file
    pointed to by 'URI' using MythDownloadManager and save it as 'FILENAME'.
    
    URI is expected to use one of http://, ftp://, or myth:// protocols
    since these are the only ones currently supported by MythDownloadManager.
  2. Attempt to fix double-install sometimes required in Theme Chooser.

    cpinkham committed Jun 15, 2013
    I believe there is a race condition between closing the busy popup
    dialog and sending the JumpTo to reload the theme after it is
    installed. This patch handles the reload in a separate event
    to allow the busy popup to close before jumping out of the
    Theme Chooser screen.
    
    References #10334.
  3. Fix some mythcommflag command line option handling.

    cpinkham committed Jun 15, 2013
    Honor the --outputmethod command line option and fix a bug in
    the handling of the --commmethod.
    
    Fixes #10989 using slightly tweaked patch by Bryan from mlewallpapers.
  4. Check user themes directory for writability before downloading theme.

    cpinkham committed Jun 15, 2013
    This patch will check that the user's themes directory (normally
    ~/.mythtv/themes on a *nix system) is writable when the user enters
    the Theme Chooser screen and warn the user if it is not writable.
    
    Another check happens at theme download time to warn the user if
    the selected theme can not be downloaded and installed if the themes
    directory is not writable.
    
    Fixes #10634.
Commits on Jun 14, 2013
  1. HTTPLiveStream::GetLiveStreamInfo fixups.

    cpinkham committed Jun 14, 2013
    Don't give the caller the URLs or source dimensions if they
    are not valid yet because transcoding has not started.
  2. Treat 'devel/*' branches as 'master' in the ThemeChooser

    cpinkham committed Jun 14, 2013
    If we assume that devel/* branches are up to date with master,
    this will allow devel/* users to download and install themes
    if they choose.
  3. Add a Dvr GetTitleInfoList Services API endpoint

    cpinkham committed Jun 14, 2013
    Currently this returns a list of unique titles/InetRef combinations,
    but it could be extended to include other info later.
  4. Content Services API fixes and minor enhancements

    cpinkham committed Jun 14, 2013
    Tell Script engine to use ScriptableContent instead of Content
    to match the other services.
    
    Fix case on StorageGroup argument to GetHash method definition.
    
    Allow GetRecordingArtworkList(), GetProgramArtworkList(), and
    GetHash() to be used in scripts.
  5. Allow HLS test page to filter recordings by Recording Group

    cpinkham committed Jun 14, 2013
    Use GetFilteredRecordedList and GetRecGroupList Dvr Service
    endpoints.
Commits on Jun 12, 2013
  1. Several mythfrontend Coverity fixes

    cpinkham committed Jun 12, 2013
    "Uninitialized pointer field" issues:
    - m_hd in AudioTest. ID 746876.
    - m_MPCM in AudioAdvancedSettings. ID 700946.  (unused variable removed)
    - m_progressDialog in VideoSetupWizard. ID 746882.
    - m_preview in ThemeChooser. ID 746883.
  2. Fixes for several mythtranscode Coverity IDs

    cpinkham committed Jun 12, 2013
    - Initialize m_last_audiotime in AudioReencodeBuffer ctor. ID 746889.
    - Initialize totalFrames in Cutter ctor. ID 1025912.
    - Check return value of preview image rename() call in main.cpp.  ID 746754.
    - Execution can not reach "NULL" in mpeg2fix.cpp. ID 746800.
  3. Fix potential HLS leakage in mythtranscode, found by Coverity

    cpinkham committed Jun 12, 2013
    Fixes 'Resource Leak' Coverity IDs 1025906, 1025907, and 1025908 along
    with a few other potential resource leaks of similar nature regarding
    HLS and the AVFormatWriters it uses in transcode.cpp.
Commits on Mar 22, 2013
  1. Fix auto-width calculation in mythtranscode.

    cpinkham committed Mar 22, 2013
    Issue discovered, corrected, and tested by 'rich0' in IRC.  Thanks.
Commits on Jan 2, 2013
  1. Bump MDM::downloadNow() timeout up to 60 seconds.

    cpinkham committed Jan 2, 2013
    The previous 10-second timeout was causing issues when trying to
    download large lineups from Schedules Direct. This commit bumps
    the downloadNow() timeout to 60 seconds.  This is a blocking call,
    so if the caller doesn't want to potentially block for that long,
    they should be use one of the non-blocking methods.
    
    Fixes #11287.
Commits on Dec 1, 2012
  1. Fix mythfrontend services API /Frontend/PlayRecording call.

    cpinkham committed Dec 1, 2012
    We don't need to convert the specified starttime toLocalTime() anymore.
Commits on Oct 12, 2012
  1. Allow some HLS API calls to be used in server side scripts.

    cpinkham committed Oct 12, 2012
    Add ScriptableContent class including:
    
      GetLiveStream
      GetLiveStreamList
      GetFilteredLiveStreamList
  2. mythtranscode code re-org

    cpinkham committed Oct 12, 2012
    Move the following classes out of transcode.cpp to make things a little
    cleaner and allow later reuse of the audio and video classes in a
    HTTP Live Streaming encoder which will not be contained within transcode.cpp.
    
      AudioBuffer
      AudioReencodeBuffer
      Cutter
      TranscodeFrameQueue (renamed to VideoDecodeBuffer)
    
    There is no new functionality in this patch, only a code re-org.
Commits on Oct 11, 2012
  1. Fix bug selecting themes with periods in the name.

    cpinkham committed Oct 11, 2012
    Convert ThemeInfo::GetDirectoryName() to use QFileInfo::fileName()
    instead of QFileInfo::baseName() so that we get the full directory
    name not just everything up to the first period.
Commits on Oct 10, 2012
  1. mythbackend webserver server side scripting enhancements

    cpinkham committed Oct 10, 2012
    - Add LOG_DEBUG level logging of all requests coming into the webserver
    
    - Don't trim whitespace and newlines from server side script files as they
      are processed.  This was sometimes messing up formatting and obfuscating
      the output where we didn't need to be.
    
    - Add .qxml as a valid server side scripting extension.
    
      .qxml files are processed like .qsp & .qjs, but return a mime type text/xml
    
    - Add ability to pass arguments to server side scripts via the URL parameters
    
      http://BACKENDIP:PORT/samples/somescript.qsp?arg1=value1&arg2=value2
      http://BACKENDIP:PORT/samples/otherscript.qsp?sort=title&limit=10&start=30
    
      Arguments are accessed within the script via the 'ARGS' array:
    
      if (ARGS["sort"] == "title")
  2. Speed up loading of mythbackend webserver front page

    cpinkham committed Oct 10, 2012
    Instead of displaying the heavyweight overview.qsp page which displays
    a gallery of preview images, etc., display the lightweight backend
    status html as the default content to speed up loading.  Most users
    aren't hitting the backend webserver to view previews.