2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/mythmediaoverlay.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ int MythMediaOverlay::GetFontStretch() const
return m_fontStretch;
}

bool MythMediaOverlay::Init(const QRect &Rect, float FontAspect)
bool MythMediaOverlay::Init(QRect Rect, float FontAspect)
{
int newstretch = static_cast<int>(lroundf(FontAspect * 100));
if (!((Rect == m_rect) && (newstretch == m_fontStretch)))
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/mythmediaoverlay.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class MythMediaOverlay : public QObject
~MythMediaOverlay() override;

void SetPlayer(MythPlayerUI* Player);
virtual bool Init(const QRect &Rect, float FontAspect);
virtual bool Init(QRect Rect, float FontAspect);
QRect Bounds() const;
int GetFontStretch() const;
bool HasWindow(const QString& Window);
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/mythplayerstate.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ MythNavigationState::MythNavigationState(int CurrentChapter, std::vector<int64_t
}

MythVideoBoundsState::MythVideoBoundsState(AdjustFillMode AdjustFill, AspectOverrideMode AspectOverride,
float HorizScale, float VertScale, const QPoint& Move)
float HorizScale, float VertScale, QPoint Move)
: m_adjustFillMode(AdjustFill),
m_aspectOverrideMode(AspectOverride),
m_manualHorizScale(HorizScale),
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/mythplayerstate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class MTV_PUBLIC MythVideoBoundsState
public:
MythVideoBoundsState() = default;
MythVideoBoundsState(AdjustFillMode AdjustFill, AspectOverrideMode AspectOverride,
float HorizScale, float VertScale, const QPoint& Move);
float HorizScale, float VertScale, QPoint Move);

AdjustFillMode m_adjustFillMode { kAdjustFill_Off };
AspectOverrideMode m_aspectOverrideMode { kAspect_Off };
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/mythplayervisualiserui.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void MythPlayerVisualiserUI::AudioPlayerStateChanged(MythAudioPlayerState State)
emit VisualiserStateChanged(m_visualiserState);
}

void MythPlayerVisualiserUI::UIScreenRectChanged(const QRect& Rect)
void MythPlayerVisualiserUI::UIScreenRectChanged(QRect Rect)
{
m_uiScreenRect = Rect;
}
Expand Down Expand Up @@ -114,7 +114,7 @@ void MythPlayerVisualiserUI::AutoVisualise(bool HaveVideo)
EnableVisualiser(true, false, "_AUTO_" + m_defaultVisualiser);
}

void MythPlayerVisualiserUI::EmbedVisualiser(bool Embed, const QRect &Rect)
void MythPlayerVisualiserUI::EmbedVisualiser(bool Embed, QRect Rect)
{
m_embedRect = Rect;
m_visualiserState.m_embedding = Embed;
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/mythplayervisualiserui.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ class MTV_PUBLIC MythPlayerVisualiserUI : public MythPlayerVideoUI

protected slots:
void InitialiseState() override;
void UIScreenRectChanged(const QRect& Rect);
void EmbedVisualiser(bool Embed, const QRect& Rect = {});
void UIScreenRectChanged(QRect Rect);
void EmbedVisualiser(bool Embed, QRect Rect = {});
void EnableVisualiser(bool Enable, bool Toggle, const QString& Name);
void AudioPlayerStateChanged(MythAudioPlayerState State);

Expand Down
10 changes: 5 additions & 5 deletions mythtv/libs/libmythtv/mythvideobounds.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -448,8 +448,8 @@ void MythVideoBounds::ApplyLetterboxing(void)
}
}

bool MythVideoBounds::InitBounds(const QSize &VideoDim, const QSize &VideoDispDim,
float Aspect, const QRect &WindowRect)
bool MythVideoBounds::InitBounds(QSize VideoDim, QSize VideoDispDim,
float Aspect, QRect WindowRect)
{
if (m_display)
{
Expand Down Expand Up @@ -521,7 +521,7 @@ void MythVideoBounds::VideoAspectRatioChanged(float Aspect)
}

/// \brief Update for new source video dimensions and aspect ratio
void MythVideoBounds::SourceChanged(const QSize &VideoDim, const QSize &VideoDispDim, float Aspect)
void MythVideoBounds::SourceChanged(QSize VideoDim, QSize VideoDispDim, float Aspect)
{
if (Aspect < 0.0F)
Aspect = m_videoAspect;
Expand Down Expand Up @@ -672,15 +672,15 @@ void MythVideoBounds::SetRotation(int Rotation)
/**
* \brief Resize Display Window
*/
void MythVideoBounds::ResizeDisplayWindow(const QRect &Rect, bool SaveVisibleRect)
void MythVideoBounds::ResizeDisplayWindow(QRect Rect, bool SaveVisibleRect)
{
if (SaveVisibleRect)
m_tmpDisplayVisibleRect = m_displayVisibleRect;
m_displayVisibleRect = Rect;
MoveResize();
}

void MythVideoBounds::EmbedPlayback(bool Embed, const QRect& Rect)
void MythVideoBounds::EmbedPlayback(bool Embed, QRect Rect)
{
if (Embed)
{
Expand Down
10 changes: 5 additions & 5 deletions mythtv/libs/libmythtv/mythvideobounds.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ class MythVideoBounds : public QObject
MythVideoBounds();
~MythVideoBounds() override = default;

bool InitBounds(const QSize &VideoDim, const QSize &VideoDispDim,
float Aspect, const QRect &WindowRect);
bool InitBounds(QSize VideoDim, QSize VideoDispDim,
float Aspect, QRect WindowRect);
void SetDisplay(MythDisplay* mDisplay);

signals:
Expand All @@ -46,12 +46,12 @@ class MythVideoBounds : public QObject
void RefreshVideoBoundsState();
void ScreenChanged (QScreen *screen);
void PhysicalDPIChanged (qreal /*DPI*/);
void SourceChanged (const QSize &VideoDim, const QSize &VideoDispDim, float Aspect);
void SourceChanged (QSize VideoDim, QSize VideoDispDim, float Aspect);
void VideoAspectRatioChanged(float Aspect);
virtual void EmbedPlayback (bool Embed, const QRect& Rect);
virtual void EmbedPlayback (bool Embed, QRect Rect);
void ToggleAdjustFill (AdjustFillMode AdjustFillMode = kAdjustFill_Toggle);
void ToggleAspectOverride (AspectOverrideMode AspectMode = kAspect_Toggle);
void ResizeDisplayWindow (const QRect &Rect, bool SaveVisibleRect);
void ResizeDisplayWindow (QRect Rect, bool SaveVisibleRect);
void MoveResize (void);
void Zoom (ZoomDirection Direction);
void ToggleMoveBottomLine (void);
Expand Down
6 changes: 3 additions & 3 deletions mythtv/libs/libmythtv/mythvideogpu.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,19 +97,19 @@ QString MythVideoGPU::VideoResizeToString(VideoResizing Resize)
return reasons.join(",");
}

void MythVideoGPU::SetVideoDimensions(const QSize& VideoDim, const QSize& VideoDispDim)
void MythVideoGPU::SetVideoDimensions(QSize VideoDim, QSize VideoDispDim)
{
m_videoDim = VideoDim;
m_videoDispDim = VideoDispDim;
}

void MythVideoGPU::SetVideoRects(const QRect& DisplayVideoRect, const QRect& VideoRect)
void MythVideoGPU::SetVideoRects(QRect DisplayVideoRect, QRect VideoRect)
{
m_displayVideoRect = DisplayVideoRect;
m_videoRect = VideoRect;
}

void MythVideoGPU::SetViewportRect(const QRect& DisplayVisibleRect)
void MythVideoGPU::SetViewportRect(QRect DisplayVisibleRect)
{
SetMasterViewport(DisplayVisibleRect.size());
}
6 changes: 3 additions & 3 deletions mythtv/libs/libmythtv/mythvideogpu.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ class MythVideoGPU : public QObject

public slots:
void UpdateColourSpace (bool PrimariesChanged);
void SetVideoDimensions(const QSize& VideoDim, const QSize& VideoDispDim);
void SetVideoRects (const QRect& DisplayVideoRect, const QRect& VideoRect);
void SetViewportRect (const QRect& DisplayVisibleRect);
void SetVideoDimensions(QSize VideoDim, QSize VideoDispDim);
void SetVideoRects (QRect DisplayVideoRect, QRect VideoRect);
void SetViewportRect (QRect DisplayVisibleRect);

protected:
virtual void ColourSpaceUpdate (bool PrimariesChanged) = 0;
Expand Down
8 changes: 4 additions & 4 deletions mythtv/libs/libmythtv/mythvideoout.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ MythVideoOutput::~MythVideoOutput()
* \brief Performs most of the initialization for VideoOutput.
* \return true if successful, false otherwise.
*/
bool MythVideoOutput::Init(const QSize& VideoDim, const QSize& VideoDispDim,
float VideoAspect, const QRect& WindowRect, MythCodecID CodecID)
bool MythVideoOutput::Init(const QSize VideoDim, const QSize VideoDispDim,
float VideoAspect, const QRect WindowRect, MythCodecID CodecID)
{
m_videoCodecID = CodecID;
bool wasembedding = IsEmbedding();
Expand Down Expand Up @@ -214,7 +214,7 @@ void MythVideoOutput::SetDeinterlacing(bool Enable, bool DoubleRate, MythDeintTy
* \bug We set the new width height and aspect ratio here, but we should
* do this based on the new video frames in Show().
*/
bool MythVideoOutput::InputChanged(const QSize& VideoDim, const QSize& VideoDispDim,
bool MythVideoOutput::InputChanged(const QSize VideoDim, const QSize VideoDispDim,
float VideoAspect, MythCodecID CodecID,
bool& /*AspectOnly*/, int ReferenceFrames, bool /*ForceChange*/)
{
Expand Down Expand Up @@ -354,7 +354,7 @@ MythVideoFrame* MythVideoOutput::GetLastShownFrame()
}

/// \brief translates caption/dvd button rectangle into 'screen' space
QRect MythVideoOutput::GetImageRect(const QRect& Rect, QRect* DisplayRect)
QRect MythVideoOutput::GetImageRect(const QRect Rect, QRect* DisplayRect)
{
qreal hscale = 0.0;
QSize video_size = GetVideoDispDim();
Expand Down
8 changes: 4 additions & 4 deletions mythtv/libs/libmythtv/mythvideoout.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ class MythVideoOutput : public MythVideoBounds

~MythVideoOutput() override;

virtual bool Init(const QSize& VideoDim, const QSize& VideoDispDim,
float VideoAspect, const QRect& WindowRect, MythCodecID CodecID);
virtual bool Init(QSize VideoDim, QSize VideoDispDim,
float VideoAspect, QRect WindowRect, MythCodecID CodecID);
virtual void SetVideoFrameRate(float playback_fps);
virtual void SetDeinterlacing(bool Enable, bool DoubleRate, MythDeintType Force = DEINT_NONE);
virtual void PrepareFrame (MythVideoFrame* Frame, FrameScanType Scan = kScan_Ignore) = 0;
virtual void RenderFrame (MythVideoFrame* Frame, FrameScanType) = 0;
virtual void RenderEnd () = 0;
virtual void EndFrame () = 0;
virtual bool InputChanged(const QSize& VideoDim, const QSize& VideoDispDim,
virtual bool InputChanged(QSize VideoDim, QSize VideoDispDim,
float VideoAspect, MythCodecID CodecID,
bool& AspectChanged, int ReferenceFrames, bool ForceChange);
virtual void GetOSDBounds(QRect& Total, QRect& Visible,
Expand Down Expand Up @@ -74,7 +74,7 @@ class MythVideoOutput : public MythVideoBounds
virtual MythVideoFrame* GetLastDecodedFrame();
virtual MythVideoFrame* GetLastShownFrame();
QString GetFrameStatus() const;
QRect GetImageRect(const QRect& Rect, QRect* DisplayRect = nullptr);
QRect GetImageRect(QRect Rect, QRect* DisplayRect = nullptr);
QRect GetSafeRect();

// These methods are only required by MythPlayerUI
Expand Down
12 changes: 6 additions & 6 deletions mythtv/libs/libmythtv/mythvideooutgpu.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
#define LOC QString("VidOutGPU: ")

MythVideoOutputGPU *MythVideoOutputGPU::Create(MythMainWindow* MainWindow, const QString& Decoder,
MythCodecID CodecID, const QSize& VideoDim,
const QSize& VideoDispDim, float VideoAspect,
MythCodecID CodecID, const QSize VideoDim,
const QSize VideoDispDim, float VideoAspect,
float FrameRate, uint PlayerFlags,
const QString& Codec, int ReferenceFrames)
{
Expand Down Expand Up @@ -207,7 +207,7 @@ void MythVideoOutputGPU::InitPictureAttributes()
m_videoColourSpace.SetSupportedAttributes(ALL_PICTURE_ATTRIBUTES);
}

void MythVideoOutputGPU::WindowResized(const QSize& Size)
void MythVideoOutputGPU::WindowResized(const QSize Size)
{
SetWindowSize(Size);
InitDisplayMeasurements();
Expand All @@ -227,8 +227,8 @@ void MythVideoOutputGPU::SetVideoFrameRate(float NewRate)
m_newFrameRate = true;
}

bool MythVideoOutputGPU::Init(const QSize& VideoDim, const QSize& VideoDispDim,
float Aspect, const QRect& DisplayVisibleRect, MythCodecID CodecId)
bool MythVideoOutputGPU::Init(const QSize VideoDim, const QSize VideoDispDim,
float Aspect, const QRect DisplayVisibleRect, MythCodecID CodecId)
{
// if we are the main video player then free up as much video memory
// as possible at startup
Expand Down Expand Up @@ -374,7 +374,7 @@ void MythVideoOutputGPU::SetReferenceFrames(int ReferenceFrames)
m_maxReferenceFrames = ReferenceFrames;
}

bool MythVideoOutputGPU::InputChanged(const QSize& VideoDim, const QSize& VideoDispDim,
bool MythVideoOutputGPU::InputChanged(QSize VideoDim, QSize VideoDispDim,
float Aspect, MythCodecID CodecId, bool& AspectOnly, int ReferenceFrames,
bool ForceChange)
{
Expand Down
12 changes: 6 additions & 6 deletions mythtv/libs/libmythtv/mythvideooutgpu.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ class MythVideoOutputGPU : public MythVideoOutput

public:
static MythVideoOutputGPU* Create(MythMainWindow* MainWindow, const QString& Decoder,
MythCodecID CodecID, const QSize& VideoDim,
const QSize& VideoDispDim, float VideoAspect,
MythCodecID CodecID, QSize VideoDim,
QSize VideoDispDim, float VideoAspect,
float FrameRate, uint PlayerFlags,
const QString& Codec, int ReferenceFrames);
~MythVideoOutputGPU() override;
Expand All @@ -25,15 +25,15 @@ class MythVideoOutputGPU : public MythVideoOutput
void PictureAttributeChanged(PictureAttribute Attribute, int Value);

public slots:
void WindowResized (const QSize& Size);
void WindowResized (QSize Size);

public:
void InitPictureAttributes () override;
void SetVideoFrameRate (float NewRate) override;
void DiscardFrames (bool KeyFrame, bool Flushed) override;
void DoneDisplayingFrame (MythVideoFrame* Frame) override;
void UpdatePauseFrame (int64_t& DisplayTimecode, FrameScanType Scan = kScan_Progressive) override;
bool InputChanged (const QSize& VideoDim, const QSize& VideoDispDim,
bool InputChanged (QSize VideoDim, QSize VideoDispDim,
float Aspect, MythCodecID CodecId, bool& AspectOnly,
int ReferenceFrames, bool ForceChange) override;
void EndFrame () override;
Expand All @@ -43,8 +43,8 @@ class MythVideoOutputGPU : public MythVideoOutput
protected:
MythVideoOutputGPU(MythRender* Render, QString &Profile);
virtual QRect GetDisplayVisibleRectAdj();
bool Init (const QSize& VideoDim, const QSize& VideoDispDim, float Aspect,
const QRect& DisplayVisibleRect, MythCodecID CodecId) override;
bool Init (QSize VideoDim, QSize VideoDispDim, float Aspect,
QRect DisplayVisibleRect, MythCodecID CodecId) override;
void PrepareFrame (MythVideoFrame* Frame, FrameScanType Scan) override;
void RenderFrame (MythVideoFrame* Frame, FrameScanType Scan) override;
void RenderOverlays (OSD& Osd) override;
Expand Down
8 changes: 4 additions & 4 deletions mythtv/libs/libmythtv/mythvideooutnull.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ MythVideoOutputNull* MythVideoOutputNull::Create(QSize VideoDim, QSize VideoDisp
return nullptr;
}

bool MythVideoOutputNull::InputChanged(const QSize& VideoDim,
const QSize& VideoDispDim,
bool MythVideoOutputNull::InputChanged(QSize VideoDim,
QSize VideoDispDim,
float Aspect,
MythCodecID CodecID,
bool& AspectOnly,
Expand Down Expand Up @@ -106,8 +106,8 @@ bool MythVideoOutputNull::InputChanged(const QSize& VideoDim,
return ok;
}

bool MythVideoOutputNull::Init(const QSize& VideoDim, const QSize& VideoDispDim,
float Aspect, const QRect& DisplayVisibleRect, MythCodecID CodecID)
bool MythVideoOutputNull::Init(const QSize VideoDim, const QSize VideoDispDim,
float Aspect, const QRect DisplayVisibleRect, MythCodecID CodecID)
{
if (VideoDispDim.isEmpty())
return false;
Expand Down
6 changes: 3 additions & 3 deletions mythtv/libs/libmythtv/mythvideooutnull.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ class MythVideoOutputNull : public MythVideoOutput
static void GetRenderOptions(RenderOptions& Options);
~MythVideoOutputNull() override = default;

bool Init(const QSize& VideoDim, const QSize& VideoDispDim,
float Aspect, const QRect& DisplayVisibleRect, MythCodecID CodecID) override;
bool Init(QSize VideoDim, QSize VideoDispDim,
float Aspect, QRect DisplayVisibleRect, MythCodecID CodecID) override;
void SetDeinterlacing(bool Enable, bool DoubleRate, MythDeintType Force = DEINT_NONE) override;

void PrepareFrame (MythVideoFrame* Frame, FrameScanType Scan) override;
void RenderFrame (MythVideoFrame* Frame, FrameScanType Scan) override;
void RenderOverlays (OSD& /*Osd*/) override { }
void RenderEnd () override { }
void EndFrame () override { }
bool InputChanged(const QSize& VideoDim, const QSize& VideoDispDim,
bool InputChanged(QSize VideoDim, QSize VideoDispDim,
float Aspect, MythCodecID CodecID,
bool& AspectOnly,
int ReferenceFrames, bool ForceChange) override;
Expand Down
6 changes: 3 additions & 3 deletions mythtv/libs/libmythtv/opengl/mythvideooutopengl.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,8 @@ MythVideoOutputOpenGL::~MythVideoOutputOpenGL()
}
}

bool MythVideoOutputOpenGL::Init(const QSize& VideoDim, const QSize& VideoDispDim,
float Aspect, const QRect& DisplayVisibleRect, MythCodecID CodecId)
bool MythVideoOutputOpenGL::Init(const QSize VideoDim, const QSize VideoDispDim,
float Aspect, const QRect DisplayVisibleRect, MythCodecID CodecId)
{
if (!(m_openglRender && m_painter && m_video))
{
Expand Down Expand Up @@ -365,7 +365,7 @@ void MythVideoOutputOpenGL::EndFrame()

/*! \brief Generate a list of supported OpenGL profiles.
*/
QStringList MythVideoOutputOpenGL::GetAllowedRenderers(MythCodecID CodecId, const QSize& /*VideoDim*/)
QStringList MythVideoOutputOpenGL::GetAllowedRenderers(MythCodecID CodecId, QSize /*VideoDim*/)
{
QStringList allowed;

Expand Down
6 changes: 3 additions & 3 deletions mythtv/libs/libmythtv/opengl/mythvideooutopengl.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ class MythVideoOutputOpenGL : public MythVideoOutputGPU
~MythVideoOutputOpenGL() override;

static void GetRenderOptions (RenderOptions& Options);
static QStringList GetAllowedRenderers(MythCodecID CodecId, const QSize& VideoDim);
static QStringList GetAllowedRenderers(MythCodecID CodecId, QSize VideoDim);
static VideoFrameTypes s_openglFrameTypes;
static VideoFrameTypes s_openglFrameTypesLegacy;

bool Init (const QSize& VideoDim, const QSize& VideoDispDim,
float Aspect, const QRect& DisplayVisibleRect, MythCodecID CodecId) override;
bool Init (QSize VideoDim, QSize VideoDispDim,
float Aspect, QRect DisplayVisibleRect, MythCodecID CodecId) override;
void PrepareFrame (MythVideoFrame* Frame, FrameScanType Scan) override;
void RenderFrame (MythVideoFrame* Frame, FrameScanType Scan) override;
void RenderEnd () override;
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/osd.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ void OSD::TearDown()
m_dialog = nullptr;
}

bool OSD::Init(const QRect &Rect, float FontAspect)
bool OSD::Init(QRect Rect, float FontAspect)
{
int newstretch = static_cast<int>(lroundf(FontAspect * 100));
if ((Rect == m_rect) && (newstretch == m_fontStretch))
Expand Down Expand Up @@ -447,7 +447,7 @@ void OSD::SetGraph(const QString &Window, const QString &Graph, int64_t Timecode
image->SetImage(mi);
}

void OSD::Draw(const QRect &Rect)
void OSD::Draw(QRect Rect)
{
bool visible = false;
QTime now = MythDate::current().time();
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/osd.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,13 @@ class OSD : public MythMediaOverlay
OSD(MythMainWindow* MainWindow, TV* Tv, MythPlayerUI* Player, MythPainter* Painter);
~OSD() override;

bool Init(const QRect &Rect, float FontAspect) override;
bool Init(QRect Rect, float FontAspect) override;
void HideWindow(const QString &Window) override;
void SetFunctionalWindow(const QString &Window, enum OSDFunctionalType Type);
void HideAll(bool KeepSubs = true, MythScreenType *Except = nullptr, bool DropNotification = false);
void SetExpiry(const QString &Window, enum OSDTimeout Timeout, int CustomTimeout = 0);
void ResetWindow(const QString &Window);
void Draw(const QRect& Rect);
void Draw(QRect Rect);

void SetValues(const QString &Window, const QHash<QString,int> &Map, OSDTimeout Timeout);
void SetValues(const QString &Window, const QHash<QString,float> &Map, OSDTimeout Timeout);
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/previewgeneratorqueue.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ PreviewGeneratorQueue::~PreviewGeneratorQueue()
*/
void PreviewGeneratorQueue::GetPreviewImage(
const ProgramInfo &pginfo,
const QSize &outputsize,
const QSize outputsize,
const QString &outputfile,
long long time, bool in_seconds,
const QString& token)
Expand Down Expand Up @@ -411,7 +411,7 @@ void PreviewGeneratorQueue::SendEvent(
*/
QString PreviewGeneratorQueue::GeneratePreviewImage(
ProgramInfo &pginfo,
const QSize &size,
const QSize size,
const QString &outputfile,
long long time, bool in_seconds,
const QString& token)
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/previewgeneratorqueue.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class MTV_PUBLIC PreviewGeneratorQueue : public QObject, public MThread
{
GetPreviewImage(pginfo, QSize(0,0), "", -1, true, token);
}
static void GetPreviewImage(const ProgramInfo &pginfo, const QSize &outputsize,
static void GetPreviewImage(const ProgramInfo &pginfo, QSize outputsize,
const QString &outputfile,
long long time, bool in_seconds,
const QString& token);
Expand All @@ -101,7 +101,7 @@ class MTV_PUBLIC PreviewGeneratorQueue : public QObject, public MThread
uint maxAttempts, uint minBlockSeconds);
~PreviewGeneratorQueue() override;

QString GeneratePreviewImage(ProgramInfo &pginfo, const QSize &size,
QString GeneratePreviewImage(ProgramInfo &pginfo, QSize size,
const QString &outputfile,
long long time, bool in_seconds,
const QString& token);
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/recorders/channelbase.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ bool ChannelBase::CheckChannel(const QString &channum) const
ChannelBase *ChannelBase::CreateChannel(
TVRec *tvrec,
const GeneralDBOptions &genOpt,
const DVBDBOptions &dvbOpt,
DVBDBOptions dvbOpt,
const FireWireDBOptions &fwOpt,
const QString &startchannel,
bool enter_power_save_mode,
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/recorders/channelbase.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class ChannelBase
static ChannelBase *CreateChannel(
TVRec *tvrec,
const GeneralDBOptions &genOpt,
const DVBDBOptions &dvbOpt,
DVBDBOptions dvbOpt,
const FireWireDBOptions &fwOpt,
const QString &startchannel,
bool enter_power_save_mode,
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/recorders/hdhrchannel.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ static QString format_dvbc(const DTVMultiplex &tuning, const QString &mod)
}

static QString get_tune_spec(
const DTVTunerType &tunerType, const DTVMultiplex &tuning)
const DTVTunerType tunerType, const DTVMultiplex &tuning)
{
const QString mod = format_modulation(tuning);

Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/recorders/recorderbase.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ class FrameRate
uint getNum(void) const { return m_num; }
uint getDen(void) const { return m_den; }
QString toString(void) const { return QString("%1/%2").arg(m_num).arg(m_den); }
bool operator==(const FrameRate &other) const {
bool operator==(const FrameRate other) const {
return m_num == other.m_num && m_den == other.m_den;
}
bool operator!=(const FrameRate &other) const { return !(*this == other); }
bool operator!=(const FrameRate other) const { return !(*this == other); }
private:
uint m_num;
uint m_den;
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/recordinginfo.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ RecordingInfo::RecordingInfo(
const QDateTime &_recendts,

float _stars,
const QDate &_originalAirDate,
QDate _originalAirDate,

bool _repeat,

Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/recordinginfo.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class MTV_PUBLIC RecordingInfo : public ProgramInfo
const QDateTime &recendts,

float stars,
const QDate &originalAirDate,
QDate originalAirDate,

bool repeat,

Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/tv_play.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6809,7 +6809,7 @@ QSet<uint> TV::IsTunableOn(PlayerContext* Context, uint ChanId)
return tunable_cards;
}

void TV::Embed(bool Embed, const QRect& Rect, const QStringList& Data)
void TV::Embed(bool Embed, QRect Rect, const QStringList& Data)
{
emit EmbedPlayback(Embed, Rect);
if (Embed)
Expand Down Expand Up @@ -6847,7 +6847,7 @@ void TV::Embed(bool Embed, const QRect& Rect, const QStringList& Data)
}
}

bool TV::DoSetPauseState(const bool& Pause)
bool TV::DoSetPauseState(bool Pause)
{
bool waspaused = ContextIsPaused(__FILE__, __LINE__);
float time = 0.0F;
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/tv_play.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ class MTV_PUBLIC TV : public TVPlaybackState, public MythTVMenuItemDisplayer, pu
void VolumeChange(bool Up, int NewVolume = -1);

private slots:
void Embed(bool Embed, const QRect& Rect = {}, const QStringList& Data = {});
void Embed(bool Embed, QRect Rect = {}, const QStringList& Data = {});

private:
static QStringList lastProgramStringList;
Expand Down Expand Up @@ -349,7 +349,7 @@ class MTV_PUBLIC TV : public TVPlaybackState, public MythTVMenuItemDisplayer, pu
float DoTogglePauseStart();
void DoTogglePauseFinish(float Time, bool ShowOSD);
void DoTogglePause(bool ShowOSD);
bool DoSetPauseState(const bool& Pause);
bool DoSetPauseState(bool Pause);
bool ContextIsPaused(const char* File, int Location);

// Program jumping stuff
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/tvplaybackstate.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* may lead to a feedback loop and/or recursion.
*/

void TVPlaybackState::OverlayStateChanged(const MythOverlayState& OverlayState)
void TVPlaybackState::OverlayStateChanged(const MythOverlayState OverlayState)
{
m_overlayState = OverlayState;
}
Expand All @@ -30,7 +30,7 @@ void TVPlaybackState::AudioStateChanged(const MythAudioState& AudioState)
m_audioState = AudioState;
}

void TVPlaybackState::CaptionsStateChanged(const MythCaptionsState& CaptionsState)
void TVPlaybackState::CaptionsStateChanged(const MythCaptionsState CaptionsState)
{
m_captionsState = CaptionsState;
}
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/tvplaybackstate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ class MTV_PUBLIC TVPlaybackState : public QObject
void EnableVisualiser(bool Enable, bool Toggle = false, const QString& Name = QString());

public slots:
void OverlayStateChanged(const MythOverlayState& OverlayState);
void OverlayStateChanged(MythOverlayState OverlayState);
void AudioPlayerStateChanged(const MythAudioPlayerState& AudioPlayerState);
void AudioStateChanged(const MythAudioState& AudioState);
void CaptionsStateChanged(const MythCaptionsState& CaptionsState);
void CaptionsStateChanged(MythCaptionsState CaptionsState);
void VideoBoundsStateChanged(const MythVideoBoundsState& VideoBoundsState);
void VisualiserStateChanged(const MythVisualiserState& VisualiserState);

Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/v4l2util.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,7 @@ bool V4L2util::OpenVBI(const QString& /*vbi_dev_name*/)
return false;
}

bool V4L2util::SetSlicedVBI(const VBIMode::vbimode_t& vbimode)
bool V4L2util::SetSlicedVBI(VBIMode::vbimode_t vbimode)
{
struct v4l2_format vbifmt {};

Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/v4l2util.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class MTV_PUBLIC V4L2util
protected:
// VBI
static bool OpenVBI(const QString& vbi_dev_name);
bool SetSlicedVBI(const VBIMode::vbimode_t& vbimode);
bool SetSlicedVBI(VBIMode::vbimode_t vbimode);

int GetExtControl(int request, const QString& ctrl_desc = "") const;
bool SetExtControl(int request, int value, const QString& ctrl_desc,
Expand Down
8 changes: 4 additions & 4 deletions mythtv/libs/libmythtv/videodisplayprofile.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ bool ProfileItem::CheckRange(const QString& Key,
return match;
}

bool ProfileItem::IsMatch(const QSize &Size, float Framerate, const QString &CodecName,
bool ProfileItem::IsMatch(QSize Size, float Framerate, const QString &CodecName,
const QStringList &DisallowedDecoders) const
{
bool match = true;
Expand Down Expand Up @@ -356,7 +356,7 @@ VideoDisplayProfile::VideoDisplayProfile()
}
}

void VideoDisplayProfile::SetInput(const QSize &Size, float Framerate, const QString &CodecName,
void VideoDisplayProfile::SetInput(QSize Size, float Framerate, const QString &CodecName,
const QStringList &DisallowedDecoders)
{
QMutexLocker locker(&m_lock);
Expand Down Expand Up @@ -502,7 +502,7 @@ void VideoDisplayProfile::SetPreference(const QString &Key, const QString &Value
}

vector<ProfileItem>::const_iterator VideoDisplayProfile::FindMatch
(const QSize &Size, float Framerate, const QString &CodecName, const QStringList& DisallowedDecoders)
(const QSize Size, float Framerate, const QString &CodecName, const QStringList& DisallowedDecoders)
{
for (auto it = m_allowedPreferences.cbegin(); it != m_allowedPreferences.cend(); ++it)
if ((*it).IsMatch(Size, Framerate, CodecName, DisallowedDecoders))
Expand All @@ -511,7 +511,7 @@ vector<ProfileItem>::const_iterator VideoDisplayProfile::FindMatch
}

void VideoDisplayProfile::LoadBestPreferences
(const QSize &Size, float Framerate, const QString &CodecName, const QStringList &DisallowedDecoders)
(const QSize Size, float Framerate, const QString &CodecName, const QStringList &DisallowedDecoders)
{
LOG(VB_PLAYBACK, LOG_INFO, LOC + QString("LoadBestPreferences(%1x%2, %3, %4)")
.arg(Size.width()).arg(Size.height())
Expand Down
8 changes: 4 additions & 4 deletions mythtv/libs/libmythtv/videodisplayprofile.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class MTV_PUBLIC ProfileItem
bool CheckRange(const QString& Key, float Value, bool *Ok = nullptr) const;
bool CheckRange(const QString& Key, int Value, bool *Ok = nullptr) const;
bool CheckRange(const QString& Key, float FValue, int IValue, bool IsFloat, bool *Ok = nullptr) const;
bool IsMatch(const QSize &Size, float Framerate, const QString &CodecName,
bool IsMatch(QSize Size, float Framerate, const QString &CodecName,
const QStringList &DisallowedDecoders = QStringList()) const;
bool IsValid(QString *Reason = nullptr) const;
bool operator<(const ProfileItem &Other) const;
Expand All @@ -71,7 +71,7 @@ class MTV_PUBLIC VideoDisplayProfile
VideoDisplayProfile();
~VideoDisplayProfile() = default;

void SetInput(const QSize &Size, float Framerate = 0, const QString &CodecName = QString(),
void SetInput(QSize Size, float Framerate = 0, const QString &CodecName = QString(),
const QStringList &DisallowedDecoders = QStringList());
void SetOutput(float Framerate);
float GetOutput(void) const;
Expand Down Expand Up @@ -118,9 +118,9 @@ class MTV_PUBLIC VideoDisplayProfile

private:
std::vector<ProfileItem>::const_iterator
FindMatch(const QSize &Size, float Framerate, const QString &CodecName,
FindMatch(QSize Size, float Framerate, const QString &CodecName,
const QStringList& DisallowedDecoders = QStringList());
void LoadBestPreferences(const QSize &Size, float Framerate, const QString &CodecName,
void LoadBestPreferences(QSize Size, float Framerate, const QString &CodecName,
const QStringList &DisallowedDecoders = QStringList());
QString GetPreference(const QString &Key) const;
void SetPreference(const QString &Key, const QString &Value);
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/videosource.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ void VideoSource::deleteEntry(void)
SourceUtil::DeleteSource(getSourceID());
}

bool VideoSourceEditor::cardTypesInclude(const int &sourceID,
bool VideoSourceEditor::cardTypesInclude(int sourceID,
const QString &thecardtype)
{
MSqlQuery query(MSqlQuery::InitCon());
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/videosource.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@ class MTV_PUBLIC VideoSourceEditor : public GroupSetting
public:
VideoSourceEditor();

static bool cardTypesInclude(const int& SourceID,
static bool cardTypesInclude(int SourceID,
const QString& thecardtype);

void Load(void) override; // StandardSetting
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/visualisations/opengl/mythvisualmonoscopeopengl.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ void MythVisualMonoScopeOpenGL::TearDown()
m_vertices.clear();
}

void MythVisualMonoScopeOpenGL::Draw(const QRect& Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/)
void MythVisualMonoScopeOpenGL::Draw(const QRect Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/)
{
MythRenderOpenGL* render = Initialise(Area);
if (!render)
Expand Down Expand Up @@ -122,7 +122,7 @@ void MythVisualMonoScopeOpenGL::Draw(const QRect& Area, MythPainter* /*Painter*/
render->doneCurrent();
}

MythRenderOpenGL* MythVisualMonoScopeOpenGL::Initialise(const QRect& Area)
MythRenderOpenGL* MythVisualMonoScopeOpenGL::Initialise(QRect Area)
{
auto * render = dynamic_cast<MythRenderOpenGL*>(m_render);
if (!render)
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/visualisations/opengl/mythvisualmonoscopeopengl.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ class MythVisualMonoScopeOpenGL : public VideoVisualMonoScope
MythVisualMonoScopeOpenGL(AudioPlayer* Audio, MythRender* Render, bool Fade);
~MythVisualMonoScopeOpenGL() override;

void Draw(const QRect& Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/) override;
void Draw(QRect Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/) override;

private:
MythRenderOpenGL* Initialise (const QRect& Area);
MythRenderOpenGL* Initialise (QRect Area);
void TearDown ();

bool m_bufferMaps { false };
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/visualisations/videovisual.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ class MTV_PUBLIC VideoVisual : public MythTV::Visual
~VideoVisual() override;

bool NeedsPrepare() const { return m_needsPrepare; }
virtual void Prepare(const QRect& /*Area*/) { }
virtual void Draw(const QRect &area, MythPainter *painter,
virtual void Prepare(const QRect /*Area*/) { }
virtual void Draw(QRect area, MythPainter *painter,
QPaintDevice* device) = 0;
virtual QString Name(void) = 0;

Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/visualisations/videovisualgoom.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ VideoVisualGoom::~VideoVisualGoom()
goom_close();
}

void VideoVisualGoom::Draw(const QRect& Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/)
void VideoVisualGoom::Draw(const QRect Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/)
{
if (m_disabled || !m_render || Area.isEmpty())
return;
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/visualisations/videovisualgoom.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class VideoVisualGoom : public VideoVisual
VideoVisualGoom(AudioPlayer* Audio, MythRender* Render, bool HD);
~VideoVisualGoom() override;

void Draw(const QRect& Area, MythPainter* Painter, QPaintDevice* Device) override;
void Draw(QRect Area, MythPainter* Painter, QPaintDevice* Device) override;
QString Name(void) override { return m_hd ? GOOMHD_NAME : GOOM_NAME; }

private:
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/visualisations/videovisualmonoscope.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ QString VideoVisualMonoScope::Name()
return m_fade ? FADE_NAME : SIMPLE_NAME;
}

void VideoVisualMonoScope::InitCommon(const QRect& Area)
void VideoVisualMonoScope::InitCommon(QRect Area)
{
m_hue = 0.0;
m_area = Area;
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/visualisations/videovisualmonoscope.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class VideoVisualMonoScope : public VideoVisual

protected:
Q_DISABLE_COPY(VideoVisualMonoScope)
void InitCommon (const QRect& Area);
void InitCommon (QRect Area);
bool UpdateVertices (float* Buffer);
void UpdateTime ();

Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/visualisations/videovisualspectrum.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ VideoVisualSpectrum::~VideoVisualSpectrum()

template<typename T> T sq(T a) { return a*a; };

void VideoVisualSpectrum::Draw(const QRect& Area, MythPainter* Painter, QPaintDevice* Device)
void VideoVisualSpectrum::Draw(const QRect Area, MythPainter* Painter, QPaintDevice* Device)
{
if (m_disabled)
return;
Expand Down Expand Up @@ -137,7 +137,7 @@ void VideoVisualSpectrum::DrawPriv(MythPainter* Painter, QPaintDevice* Device)
Painter->End();
}

bool VideoVisualSpectrum::Initialise(const QRect& Area)
bool VideoVisualSpectrum::Initialise(const QRect Area)
{
if (Area == m_area)
return true;
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/visualisations/videovisualspectrum.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ class VideoVisualSpectrum : public VideoVisual
VideoVisualSpectrum(AudioPlayer* Audio, MythRender* Render);
~VideoVisualSpectrum() override;

void Draw (const QRect& Area, MythPainter* Painter, QPaintDevice* Device) override;
void Draw (QRect Area, MythPainter* Painter, QPaintDevice* Device) override;
QString Name () override { return SPECTRUM_NAME; }
void prepare () override;

protected:
virtual bool Initialise (const QRect& Area);
virtual bool Initialise (QRect Area);
virtual bool InitialisePriv ();
virtual void DrawPriv (MythPainter* Painter, QPaintDevice* Device);

Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/visualisations/vulkan/mythvisualcirclesvulkan.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ void MythVisualCirclesVulkan::DrawPriv(MythPainter* /*Painter*/, QPaintDevice* /

}

MythRenderVulkan* MythVisualCirclesVulkan::InitialiseVulkan(const QRect& Area)
MythRenderVulkan* MythVisualCirclesVulkan::InitialiseVulkan(const QRect Area)
{
if (m_disabled)
return nullptr;
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/visualisations/vulkan/mythvisualcirclesvulkan.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class MythVisualCirclesVulkan : public VideoVisualCircles, public MythVisualVulk
void DrawPriv(MythPainter* /*Painter*/, QPaintDevice* /*Device*/) override;

private:
MythRenderVulkan* InitialiseVulkan (const QRect& Area) override;
MythRenderVulkan* InitialiseVulkan (QRect Area) override;
void TearDownVulkan () override;

CirclesBuffer m_pushBuffer { };
Expand Down
6 changes: 3 additions & 3 deletions mythtv/libs/libmythtv/visualisations/vulkan/mythvisualmonoscopevulkan.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ MythVisualMonoScopeVulkan::~MythVisualMonoScopeVulkan()
MythVisualMonoScopeVulkan::TearDownVulkan();
}

void MythVisualMonoScopeVulkan::Prepare(const QRect &Area)
void MythVisualMonoScopeVulkan::Prepare(const QRect Area)
{
if (!InitialiseVulkan(Area))
return;
Expand Down Expand Up @@ -234,7 +234,7 @@ void MythVisualMonoScopeVulkan::Prepare(const QRect &Area)
vertex.first->Update(nullptr);
}

void MythVisualMonoScopeVulkan::Draw(const QRect& Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/)
void MythVisualMonoScopeVulkan::Draw(const QRect Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/)
{
if (!InitialiseVulkan(Area))
return;
Expand Down Expand Up @@ -295,7 +295,7 @@ void MythVisualMonoScopeVulkan::Draw(const QRect& Area, MythPainter* /*Painter*/
}
}

MythRenderVulkan* MythVisualMonoScopeVulkan::InitialiseVulkan(const QRect& Area)
MythRenderVulkan* MythVisualMonoScopeVulkan::InitialiseVulkan(const QRect Area)
{
if (m_disabled)
return nullptr;
Expand Down
6 changes: 3 additions & 3 deletions mythtv/libs/libmythtv/visualisations/vulkan/mythvisualmonoscopevulkan.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ class MythVisualMonoScopeVulkan : public VideoVisualMonoScope, public MythVisual
MythVisualMonoScopeVulkan(AudioPlayer* Audio, MythRender* Render, bool Fade);
~MythVisualMonoScopeVulkan() override;

void Prepare (const QRect& Area) override;
void Draw (const QRect& Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/) override;
void Prepare (QRect Area) override;
void Draw (QRect Area, MythPainter* /*Painter*/, QPaintDevice* /*Device*/) override;

private:
MythRenderVulkan* InitialiseVulkan (const QRect& Area) override;
MythRenderVulkan* InitialiseVulkan (QRect Area) override;
void TearDownVulkan () override;

VertexStates m_vertexBuffers;
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/visualisations/vulkan/mythvisualvulkan.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ MythVisualVulkan::~MythVisualVulkan()
MythVisualVulkan::TearDownVulkan();
}

MythRenderVulkan* MythVisualVulkan::InitialiseVulkan(const QRect& /*Area*/)
MythRenderVulkan* MythVisualVulkan::InitialiseVulkan(const QRect /*Area*/)
{
if (!IsValidVulkan())
return nullptr;
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/visualisations/vulkan/mythvisualvulkan.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class MythVisualVulkan : public MythVulkanObject
const MythBindingMap* Bindings);
virtual ~MythVisualVulkan();

virtual MythRenderVulkan* InitialiseVulkan(const QRect& /*Area*/);
virtual MythRenderVulkan* InitialiseVulkan(QRect /*Area*/);
virtual void TearDownVulkan ();

protected:
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/vulkan/mythvideooutputvulkan.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ MythVideoOutputVulkan::MythVideoOutputVulkan(QString &Profile)
LOG(VB_GENERAL, LOG_ERR, LOC + "Failed to initialise Vulkan video output");
}

bool MythVideoOutputVulkan::Init(const QSize& VideoDim, const QSize& VideoDispDim,
float Aspect, const QRect& DisplayVisibleRect, MythCodecID CodecId)
bool MythVideoOutputVulkan::Init(const QSize VideoDim, const QSize VideoDispDim,
float Aspect, const QRect DisplayVisibleRect, MythCodecID CodecId)
{
if (!(IsValidVulkan() && m_painter && m_video))
{
Expand Down
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/vulkan/mythvideooutputvulkan.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class MythVideoOutputVulkan : public MythVideoOutputGPU, public MythVulkanObject
MythVideoOutputVulkan(QString& Profile);
~MythVideoOutputVulkan() override = default;

bool Init(const QSize& VideoDim, const QSize& VideoDispDim, float Aspect,
const QRect& DisplayVisibleRect, MythCodecID CodecId) override;
bool Init(QSize VideoDim, QSize VideoDispDim, float Aspect,
QRect DisplayVisibleRect, MythCodecID CodecId) override;
void PrepareFrame (MythVideoFrame* Frame, FrameScanType Scan) override;
void RenderFrame (MythVideoFrame* Frame, FrameScanType Scan) override;
void RenderEnd () override;
Expand Down