2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/io/mythinteractivebuffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ MythInteractiveBuffer::MythInteractiveBuffer(const QString &Url, MythMediaBuffer
m_parent(Parent)
{
m_startReadAhead = true;
OpenFile(Url);
MythInteractiveBuffer::OpenFile(Url);
}

MythInteractiveBuffer::~MythInteractiveBuffer()
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/mheg/interactivescreen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
InteractiveScreen::InteractiveScreen(MythPlayer *player,
const QString &name) :
MythScreenType((MythScreenType*)nullptr, name),
m_player(player), m_safeArea(QRect())
m_player(player)
{
UpdateArea();
}
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ DVBStreamData::DVBStreamData(uint desired_netid, uint desired_tsid,

DVBStreamData::~DVBStreamData()
{
Reset(m_desiredNetId, m_desiredTsId, m_desiredProgram);
DVBStreamData::Reset(m_desiredNetId, m_desiredTsId, m_desiredProgram);

QMutexLocker locker(&m_listenerLock);
m_dvbMainListeners.clear();
Expand Down
3 changes: 2 additions & 1 deletion mythtv/libs/libmythtv/mythplayer.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define MYTHPLAYER_H

#include <cstdint>
#include <utility>

#include <QCoreApplication>
#include <QList>
Expand Down Expand Up @@ -136,7 +137,7 @@ class DecoderCallback
public:
using Callback = void (*)(void*, void*, void*);
DecoderCallback() = default;
DecoderCallback(const QString &Debug, Callback Function, QAtomicInt *Ready,
DecoderCallback(QString Debug, Callback Function, QAtomicInt *Ready,
void *Opaque1, void *Opaque2, void *Opaque3)
: m_debug(std::move(Debug)),
m_function(Function),
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/mythvideooutnull.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ void MythVideoOutputNull::Show(FrameScanType /*scan*/)
{
}

void MythVideoOutputNull::UpdatePauseFrame(int64_t &disp_timecode, FrameScanType)
void MythVideoOutputNull::UpdatePauseFrame(int64_t &disp_timecode, FrameScanType /*Scan*/)
{
QMutexLocker locker(&m_globalLock);

Expand Down
1 change: 0 additions & 1 deletion mythtv/libs/libmythtv/opengl/mythopengltonemap.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#endif

MythOpenGLTonemap::MythOpenGLTonemap(MythRenderOpenGL *Render, VideoColourSpace *ColourSpace)
: QObject()
{
if (Render)
{
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/opengl/mythopenglvideo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ void MythOpenGLVideo::CleanupDeinterlacers(void)
if ((m_inputType == FMT_YV12) && (m_profile == "opengl"))
m_outputType = FMT_YUY2;
SetupFrameFormat(m_inputType, m_outputType, m_videoDim, m_textureTarget);
emit OutputChanged(m_videoDim, m_videoDim, -1.0f);
emit OutputChanged(m_videoDim, m_videoDim, -1.0F);
}
m_fallbackDeinterlacer = DEINT_NONE;
m_deinterlacer = DEINT_NONE;
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/recorders/ExternalChannel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ uint ExternalChannel::GetTuneStatus(void)
.arg(m_systemStatus));

QString result;
int ret;
int ret = 0;

if (!m_streamHandler->ProcessCommand("TuneStatus?", result))
{
Expand Down
1 change: 1 addition & 0 deletions mythtv/libs/libmythtv/videodbcheck.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,7 @@ bool doUpgradeVideoDatabaseSchema(void)
if (dbver == "1032")
{
DBUpdates updates {
// NOLINTNEXTLINE(bugprone-suspicious-missing-comma)
"CREATE TEMPORARY TABLE bad_videometadatacast"
" AS SELECT * FROM videometadatacast,",
"CREATE TEMPORARY TABLE bad_videometadatagenre"
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/videodisplayprofile.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class MTV_PUBLIC VideoDisplayProfile
private:
vector<ProfileItem>::const_iterator
FindMatch(const QSize &Size, float Framerate, const QString &CodecName,
const QStringList DisallowedDecoders = QStringList());
QStringList DisallowedDecoders = QStringList());
void LoadBestPreferences(const QSize &Size, float Framerate, const QString &CodecName,
const QStringList &DisallowedDecoders = QStringList());
QString GetPreference(const QString &Key) const;
Expand Down
5 changes: 1 addition & 4 deletions mythtv/libs/libmythui/mythmainwindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,7 @@ struct MPData {
class MythMainWindowPrivate
{
public:
MythMainWindowPrivate() :
m_gesture(MythGesture())
{
}
MythMainWindowPrivate() = default;

static int TranslateKeyNum(QKeyEvent *e);

Expand Down
5 changes: 2 additions & 3 deletions mythtv/libs/libmythui/mythuiwebbrowser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -836,12 +836,11 @@ QWebView *MythWebView::createWindow(QWebPage::WebWindowType /* type */)
MythUIWebBrowser::MythUIWebBrowser(MythUIType *parent, const QString &name)
: MythUIType(parent, name),
m_parentScreen(nullptr),
m_browser(nullptr), m_browserArea(MythRect()),
m_actualBrowserArea(MythRect()), m_image(nullptr),
m_browser(nullptr), m_image(nullptr),
m_active(false), m_wasActive(false),
m_initialized(false),
m_updateInterval(0), m_zoom(1.0),
m_bgColor("White"), m_widgetUrl(QUrl()), m_userCssFile(""),
m_bgColor("White"), m_userCssFile(""),
m_defaultSaveDir(GetConfDir() + "/MythBrowser/"),
m_defaultSaveFilename(""),
m_inputToggled(false), m_lastMouseAction(""),
Expand Down
2 changes: 1 addition & 1 deletion mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ MythRenderOpenGL::~MythRenderOpenGL()
return;
disconnect(this, &QOpenGLContext::aboutToBeDestroyed, this, &MythRenderOpenGL::contextToBeDestroyed);
if (m_ready)
ReleaseResources();
MythRenderOpenGL::ReleaseResources();
}

void MythRenderOpenGL::messageLogged(const QOpenGLDebugMessage &Message)
Expand Down
3 changes: 1 addition & 2 deletions mythtv/libs/libmythui/screensaver-dbus.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ class ScreenSaverDBusPrivate
};

ScreenSaverDBus::ScreenSaverDBus() :
m_bus(QDBusConnection::sessionBus()),
m_dbusPrivateInterfaces(QList<ScreenSaverDBusPrivate *>())
m_bus(QDBusConnection::sessionBus())
{
// service, path, interface, bus - note that interface = service, hence it is used twice
for (uint i=0; i < NUM_DBUS_METHODS; i++) {
Expand Down
3 changes: 1 addition & 2 deletions mythtv/libs/libmythui/screensaver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
QEvent::Type ScreenSaverEvent::kEventType =
static_cast<QEvent::Type>(QEvent::registerEventType());

ScreenSaverControl::ScreenSaverControl() :
m_screenSavers(QList<ScreenSaver *>())
ScreenSaverControl::ScreenSaverControl()
{
#if defined(USING_DBUS)
m_screenSavers.push_back(new ScreenSaverDBus());
Expand Down
2 changes: 0 additions & 2 deletions mythtv/programs/mythbackend/scheduler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ Scheduler::Scheduler(bool runthread, QMap<int, EncoderLink *> *tvList,
m_specSched(master_sched),
m_tvList(tvList),
m_doRun(runthread),
m_livetvTime(QDateTime()),
m_lastPrepareTime(QDateTime()),
m_openEnd(openEndNever)
{
char *debug = getenv("DEBUG_CONFLICTS");
Expand Down
4 changes: 1 addition & 3 deletions mythtv/programs/mythexternrecorder/MythExternRecApp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ bool MythExternRecApp::Open(void)
return true;
}

void MythExternRecApp::TerminateProcess(QProcess & proc, const QString & desc)
void MythExternRecApp::TerminateProcess(QProcess & proc, const QString & desc) const
{
if (proc.state() == QProcess::Running)
{
Expand All @@ -201,8 +201,6 @@ void MythExternRecApp::TerminateProcess(QProcess & proc, const QString & desc)
proc.kill();
proc.waitForFinished();
}

return;
}

Q_SLOT void MythExternRecApp::Close(void)
Expand Down
2 changes: 1 addition & 1 deletion mythtv/programs/mythexternrecorder/MythExternRecApp.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class MythExternRecApp : public QObject

protected:
void GetChannel(const QString & serial, const QString & func);
void TerminateProcess(QProcess & proc, const QString & desc);
void TerminateProcess(QProcess & proc, const QString & desc) const;

private:
bool config(void);
Expand Down
7 changes: 5 additions & 2 deletions mythtv/programs/mythfilldatabase/xmltvparser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,10 @@ bool XMLTVParser::parseFile(
return false;
}

QString programid, season, episode, totalepisodes;
QString programid;
QString season;
QString episode;
QString totalepisodes;
auto *pginfo = new ProgInfo();

QString text = xml.attributes().value("start").toString();
Expand Down Expand Up @@ -328,7 +331,7 @@ bool XMLTVParser::parseFile(
{
QString text2=xml.readElementText(QXmlStreamReader::SkipChildElements);
if (xml.attributes().value("lang").toString() == "ja_JP")
{
{ // NOLINT(bugprone-branch-clone)
pginfo->m_title = text2;
}
else if (xml.attributes().value("lang").toString() == "ja_JP@kana")
Expand Down
6 changes: 2 additions & 4 deletions mythtv/programs/mythfrontend/upnpscanner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,13 @@ class MediaServer : public MediaServerItem
public:
MediaServer()
: MediaServerItem(QString("0"), QString(), QString(), QString()),
m_controlURL(QUrl()),
m_eventSubURL(QUrl()), m_eventSubPath(QString()),
m_eventSubPath(QString()),
m_friendlyName(QString("Unknown"))
{
}
explicit MediaServer(QUrl URL)
: MediaServerItem(QString("0"), QString(), QString(), QString()),
m_url(std::move(URL)), m_controlURL(QUrl()),
m_eventSubURL(QUrl()), m_eventSubPath(QString()),
m_url(std::move(URL)), m_eventSubPath(QString()),
m_friendlyName(QString("Unknown"))
{
}
Expand Down
3 changes: 1 addition & 2 deletions mythtv/programs/mythmetadatalookup/lookup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@

#include "metadataimagehelper.h"

LookerUpper::LookerUpper() :
m_busyRecList(QList<ProgramInfo*>())
LookerUpper::LookerUpper()
{
m_metadataFactory = new MetadataFactory(this);
}
Expand Down