Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programme guide now lost category colours #291

Closed
bib1963 opened this issue Dec 12, 2020 · 2 comments
Closed

Programme guide now lost category colours #291

bib1963 opened this issue Dec 12, 2020 · 2 comments

Comments

@bib1963
Copy link

bib1963 commented Dec 12, 2020

  • Platform:

  • MythTV version:
    git head 20201212

commit 85e2689 (patch)
tree 76b923f938c065fb830835ea639b0488bf7a85f1
parent aca7df4 (diff)

  • Package version:

  • Component:

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behaviour?

What do you see instead?

Additional information

If you view the programme guide, all the category colours are now missing. They were there with git head from 20201128.

I assume this is problem with the diff MythRenderOpenGL: Greatly simplify drawing rounded rects.

@Jpilk
Copy link

Jpilk commented Dec 13, 2020

@Jpilk
Copy link

Jpilk commented Dec 13, 2020

Yes, that fixed the headline, issue and the cutlist cursor is back. Great. It looks a bit untidy at each end of the range, though; has it ever been/would it be easy to make it masked ?

mark-kendall added a commit to mark-kendall/mythtv that referenced this issue Dec 23, 2020
- the rectangle shader does not work as intended with a radius which is
less than 1 (due to the antialising bounds in the smoothstep function)
- I suspect the old shaders had the same limitation which is why the
radius of a rectangle was always forced to 1.
- revert to old behaviour of forcing a minimum radius and add an extra
check in MythRenderOpenGL::DrawRoundRect in case a rounded rect is
defined without a radius.

Fixes MythTV#291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants