Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden dependency to 3rd party module python-dateutil #347

Closed
rcrdnalor opened this issue Mar 29, 2021 · 1 comment
Closed

Remove hidden dependency to 3rd party module python-dateutil #347

rcrdnalor opened this issue Mar 29, 2021 · 1 comment
Assignees
Labels
bug:general General Bugs component:bindings:python Python Bindings version:master Master Development Branch version:v33-fixes fixes/33
Milestone

Comments

@rcrdnalor
Copy link
Contributor

  • Platform: Linux

  • MythTV version: master and v31

  • Package version:

  • Component: MythTV Python Bindings

What steps will reproduce the bug?

Run the grabber 'tvmaze.py' without installed package 'python-dateutil' results to trace back
'ModuleNotFound'

How often does it reproduce? Is there a required condition?

Every time

What is the expected behaviour?

No traceback, functional graber instead

What do you see instead?

Traceback complaining about 'ModuleNotFound'

Additional information

The new grabber tvmaze.py introduced a hidden dependency to
the parser inside the package python-dateutil:
from dateutil import parser

Note: The python module 'dateutil' provides time zone support
for the python 'datetime' module and is outdated in favor
of the new zone info module
https://docs.python.org/3/library/zoneinfo.html
MythTV's python package already provides IANA time zone support
within it's custom implementation of 'datetime'.

Given the fact, that most of the distributions do not install
python-dateutil or python3-dateutil by default anymore,
we need to either remove it, or declare it as an official
dependency.

@rcrdnalor rcrdnalor mentioned this issue Mar 29, 2021
3 tasks
@rcrdnalor rcrdnalor self-assigned this Mar 31, 2021
@rcrdnalor rcrdnalor added bug:general General Bugs component:bindings:python Python Bindings version:master Master Development Branch version:v33-fixes fixes/33 labels Mar 31, 2021
@rcrdnalor rcrdnalor added this to the 31.1 milestone Mar 31, 2021
@rcrdnalor
Copy link
Contributor Author

Implemented on master by 99c3ec2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:general General Bugs component:bindings:python Python Bindings version:master Master Development Branch version:v33-fixes fixes/33
Projects
None yet
Development

No branches or pull requests

2 participants