Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MythCenter-wide theme -- recording date and time not correctly formatted #578

Closed
daveu8282 opened this issue Jun 3, 2022 · 3 comments
Closed

MythCenter-wide theme -- recording date and time not correctly formatted #578

daveu8282 opened this issue Jun 3, 2022 · 3 comments
Assignees
@kmdewaal

Comments

@daveu8282
Copy link

  • Platform: Fedora Linux 35

  • MythTV version: fixes/31 (v32.0-v32.0-30-g26079f815a)

  • Package version: rpmfusion/mythtv-base-themes-32.0-1.30.20220510git26079f815a.fc35.x86_64

  • Component: frontend

What steps will reproduce the bug?

  1. Switch to MythCenter-wide theme using Setup / Theme Chooser
  2. Verify that a 12-hour (USA style) time format is selected using Setup / Appearance / Localization.
  3. Visit Media Library / Watch Recordings.
  4. In the upper-right pane where the episodes are listed, the date and time will be incorrectly formatted when the hour is two digits wide.

Instead of 6/2 10:00 AM it reads 6/2 10 ...
Instead of 6/2 10:00 PM it reads 6/210:00 PM

Date and time when the hour is one digit are formatted correctly:

6/2 9:00 AM
6/2 9:00 PM

Note that the similar MythCenter theme is not affected by this issue. With that theme, dates and times are always formatted correctly.

How often does it reproduce? Is there a required condition?

It always occurs if the MythCenter-wide theme is in effect.

What is the expected behaviour?

Dates and times should be consistently formatted.

Correctly formatted date and times:

6/2 10:00 AM
6/2 10:00 PM

What do you see instead?

6/2 10 ...
6/210:00 PM

Additional information
@Jpilk
Copy link

Jpilk commented Jul 15, 2022

There's more about this in the thread that led to the creation of this Issue:
http://lists.mythtv.org/pipermail/mythtv-users/2022-June/409742.html
and Issue #582 is also about the formatting of this display.

@kmdewaal kmdewaal self-assigned this Jul 25, 2022
@kmdewaal
Copy link
Contributor

The "watched percentage" and "recorded percentage" feature in version 32 does need a bit of screen space.
Part of the space for the percentage was found by reducing the size of the start time field.
Unfortunately, what needs to be displayed in the start time field is just as big as it was, causing the problem described here.
The solution is to make the title field shorter, move the percentage and date fields to the left and increase the size of the start time field.

kmdewaal added a commit that referenced this issue Jul 26, 2022
@kmdewaal
Size of recording start time field in MythCenter-wide
50c58fb 
Increase the width of the field showing the recording
start time in theme MythCenter-wide from 94 to 104.
This makes the field wide enough to show time values
in the AM/PM time presentation mode.

Refs #578
kmdewaal added a commit that referenced this issue Jul 26, 2022
@kmdewaal
Size of recording start time field in MythCenter-wide
d761e9f 
Increase the width of the field showing the recording
start time in theme MythCenter-wide from 94 to 104.
This makes the field wide enough to show time values
in the AM/PM time presentation mode.

Refs #578

(cherry picked from commit 50c58fb)
@kmdewaal
Copy link
Contributor

Problem is solved, closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmdewaal kmdewaal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jpilk @kmdewaal @daveu8282