-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get banners of english season, if asked lang has none. #180
Conversation
|
Trac ticket https://code.mythtv.org/trac/ticket/13424 was closed as fixed upon the author of this ticket. |
|
Banner and Fanart works, Covers not. |
…r given language The grabber script tmdb3.py already sorts the posters by the given language, but if no poster of given language was found, we sort by system language and then by language "en". Refs #180
|
Please check pull request #377 for a successor of the ttvdb api 3.x . |
|
I tried to check this out but always get High Level version mismatch v31-Pre-4650-h59... against 32.20200101-1. |
|
In order to test this branch on the command line, you need to
In case you are using the 'fixes/31' or below installation, |
|
Sorry for the late reply, I still don't get it. I copied the 2 folders to ~/mm, but I don't have any MythTV folder either in ~/mm nor in ~ at all. And for the --test run, how can I see if the data I was missing for my videos get downloaded with these tests? |
|
The API v3 from TheTVDB is marked as deprecated. Feedback is welcome |
|
Feedback: Before adding a new season to check the banner, I added remaining episodes of the last one to get only the new season in the test. Problem: In german Arrow S01E02 and S07E17 have the exact same title, console shows:
The main window shows me to select between Arrow (2012) and Arrow (2012) which is not really a usefull help for a decision, and no matter what I choose, the 6 lines above just repeat. |
|
With the arclight theme, at least the covers are shown, so I guess all needed information is there. Short test on cmd-line |
|
Closing as problem is solved |
Fixes: 13424
I was a bit annoyed by this one for some time. This patch lets ttvdb.py just generate a second request with lang set to english and merge the missing stuff into original output.
I tested with a newly added season aswell as with seasons already missing the posters.
As I had no experience with python 2 days ago, it's maybe not the most beautiful solution, but a working one.