Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get banners of english season, if asked lang has none. #180

Closed
wants to merge 5 commits into from
Closed

Get banners of english season, if asked lang has none. #180

wants to merge 5 commits into from

Conversation

Vollstrecker
Copy link

Fixes: 13424

I was a bit annoyed by this one for some time. This patch lets ttvdb.py just generate a second request with lang set to english and merge the missing stuff into original output.

I tested with a newly added season aswell as with seasons already missing the posters.

As I had no experience with python 2 days ago, it's maybe not the most beautiful solution, but a working one.

@Vollstrecker Vollstrecker changed the title Get banners of english season, of asked lang has none. Get banners of english season, if asked lang has none. Apr 4, 2019
@stuarta stuarta added this to Needs triage in Bug Triage Sep 1, 2020
@rcrdnalor rcrdnalor added component:bindings:python Python Bindings version:master Master Development Branch version:v33-fixes fixes/33 labels Oct 2, 2020
@rcrdnalor
Copy link
Contributor

Trac ticket https://code.mythtv.org/trac/ticket/13424 was closed as fixed upon the author of this ticket.
Could you please re-test ?

@Vollstrecker
Copy link
Author

Banner and Fanart works, Covers not.

rcrdnalor added a commit that referenced this pull request Dec 8, 2020
…r given language

The grabber script tmdb3.py  already sorts the posters
by the given language, but if no poster of given language
was found, we sort by system language and then by language "en".

Refs #180
rcrdnalor added a commit that referenced this pull request Dec 8, 2020
…r given language

The grabber script tmdb3.py  already sorts the posters
by the given language, but if no poster of given language
was found, we sort by system language and then by language "en".

Refs #180

(cherry picked from commit 2940cbc)
@rcrdnalor
Copy link
Contributor

Please check pull request #377 for a successor of the ttvdb api 3.x .

@Vollstrecker
Copy link
Author

I tried to check this out but always get High Level version mismatch v31-Pre-4650-h59... against 32.20200101-1.

@rcrdnalor
Copy link
Contributor

In order to test this branch on the command line, you need to

  • checkout it
  • copy the 'mythtv/bindings/python' folder to a folder in a sub-folder of your $HOME
  • copy 'mythtv/programs/scripts/metadata/Television/*' to the same folder
  • create relative symlinks inside the 'MythTV' folder by
    • ln -s ../tvmaze
    • ln -s ../ttvdbv4
    • ln -s ../ttvdb
    • ln -s ../tmdb3/tmdb3
  • run './ttvbv4.py --test'
    and check if everything is in place.

In case you are using the 'fixes/31' or below installation,
you need to change the file 'MythTV/static.py' and adapt the
SCHEMA_VERSION to the schema used on your branch.

@Vollstrecker
Copy link
Author

Sorry for the late reply, I still don't get it. I copied the 2 folders to ~/mm, but I don't have any MythTV folder either in ~/mm nor in ~ at all. And for the --test run, how can I see if the data I was missing for my videos get downloaded with these tests?

@rcrdnalor
Copy link
Contributor

The API v3 from TheTVDB is marked as deprecated.
The successor of 'ttvdb.py' named 'ttvdb4.py' is now available on the fixes/31 branch of MythTV.
If you want to activate it, read the commit message of a7826be

Feedback is welcome

@Vollstrecker
Copy link
Author

Feedback: Before adding a new season to check the banner, I added remaining episodes of the last one to get only the new season in the test. Problem: In german Arrow S01E02 and S07E17 have the exact same title, console shows:

2022-01-20 10:40:26.267621 I Manual Metadata Lookup: Selected Item: Type: Video : Subtype: Television : InetRef: ttvdb4.py_257655
2022-01-20 10:40:28.168362 I Running Grabber: /usr/share/mythtv/metadata/Television/ttvdb4.py -l de -a DE -N 257655 Das Vermächtnis
2022-01-20 10:40:29.422692 I Result Found, Season 1 Episode 2
2022-01-20 10:40:29.423128 I Result Found, Season 7 Episode 17
2022-01-20 10:40:29.424295 I Running Grabber: /usr/share/mythtv/metadata/Television/ttvdb4.py -l de -a DE -D 257655
2022-01-20 10:40:29.571315 I Returning Metadata Results: Arrow 1 2

The main window shows me to select between Arrow (2012) and Arrow (2012) which is not really a usefull help for a decision, and no matter what I choose, the 6 lines above just repeat.

Screenshot

@Vollstrecker
Copy link
Author

With the arclight theme, at least the covers are shown, so I guess all needed information is there. Short test on cmd-line
/usr/share/mythtv/metadata/Television/ttvdb4.py -l de -a DE -D 257655 07 17
gives the right data. Maybe this would be a better way of calling the script.

@Vollstrecker
Copy link
Author

Closing as problem is solved

Bug Triage automation moved this from Needs triage to Closed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:bindings:python Python Bindings version:master Master Development Branch version:v33-fixes fixes/33
Projects
Bug Triage
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants