Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Improve UPNP sort order for TV recordings #19

Closed
wants to merge 2 commits into from

3 participants

@josephlord

It can be very hard to use the current sort order for the content items over UPNP especially if you have large numbers of a title and don't know the exact date of the recording.

This patch adds logical folders for date sorted versions of the listings by title and it also applies a subtitle sort to the non-date sorted title list to help where you know the particular episode that you want.

I have tested these changes on Ubuntu Precise but have not built from the Git source. I think that this is a very low risk change.

I understand if the design choices you make do not want to offer all these choices but as a heavy UPNP user I would strongly request that you do make a user obvious sort apply to the title grouped content (and I suggest by date). I also understand if you need to change the names, especially if internationalisation is required but I wanted to offer this upstream anyway.

@dekarl
Owner

the corresponding ticket is http://code.mythtv.org/trac/ticket/10687

@stuartm stuartm self-assigned this
@stuartm
Owner

Thanks for the patches, I'm going to address this in 0.28 but do it a little bit differently by supporting node depths of more than two. We can also support sorting by season and episode in 0.28.

@stuartm stuartm closed this
@stuartm
Owner

Since you are a UPnP user you may be interested in using master since a lot of improvements are currently being made to UPnP for what will become 0.28.

@josephlord

No problem. I do really like date sorting at least where the series information isn't present but nested within a title option or something like that would be fine. I'm happy to test (and run by my wife) what you come up with and let you know if it works for us. I'll give master a try soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 3, 2012
  1. @josephlord
  2. @josephlord

    Changed the sort on the non-date title groupings to be by subtitle as…

    josephlord authored
    … sorting by title often doesn't help very much.
This page is out of date. Refresh to see the latest.
Showing with 24 additions and 2 deletions.
  1. +24 −2 mythtv/programs/mythbackend/upnpcdstv.cpp
View
26 mythtv/programs/mythbackend/upnpcdstv.cpp
@@ -49,7 +49,7 @@ UPnpCDSRootInfo UPnpCDSTv::g_RootNodes[] =
"ORDER BY starttime DESC",
"", "starttime DESC" },
- { "By Title",
+ { "By Title (newest first)",
"title",
"SELECT title as id, "
"title as name, "
@@ -58,7 +58,29 @@ UPnpCDSRootInfo UPnpCDSTv::g_RootNodes[] =
"%1 "
"GROUP BY title "
"ORDER BY title",
- "WHERE title=:KEY", "title" },
+ "WHERE title=:KEY", "starttime DESC" },
+
+ { "By Title (oldest first)",
+ "title",
+ "SELECT title as id, "
+ "title as name, "
+ "count( title ) as children "
+ "FROM recorded "
+ "%1 "
+ "GROUP BY title "
+ "ORDER BY title",
+ "WHERE title=:KEY", "starttime" },
+
+ { "By Title (ordered by subtitle)",
+ "title",
+ "SELECT title as id, "
+ "title as name, "
+ "count( title ) as children "
+ "FROM recorded "
+ "%1 "
+ "GROUP BY title "
+ "ORDER BY title",
+ "WHERE title=:KEY", "subtitle" },
{ "By Genre",
"category",
Something went wrong with that request. Please try again.