Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend metadatagrabber timeout to 3 minutes #199

Merged

Conversation

bhulsken
Copy link
Contributor

@bhulsken bhulsken commented Jul 7, 2020

ttvdb and tmdb are sometimes quite slow to respond to queries, and the 60 seconds timeout is really too short. Extending it to 180s (3 minutes) solves issues for me, and allow fetching of metadata for all movies / series in my library (which are many).

I have a very fast (fiber) internet connection, so the issue is not my connection, also multiple reports on this issue can be found on the web. For some reason, slower replies of tmdb seem linked to certain movies. Meaning that some queries yield a reply in less than 60 seconds, yet consistent repeated queries for certain movies never return a result within 60 seconds.

@stuarta stuarta added this to Needs triage in Bug Triage Sep 1, 2020
@warpme
Copy link
Contributor

warpme commented Sep 25, 2020

I have the same observations and confirm this change reduces false positives where user thinks issue is within mythtv metagrabber while real root cause is slow repose from metadata source.

@mark-kendall mark-kendall merged commit 90993ca into MythTV:master Sep 25, 2020
Bug Triage automation moved this from Needs triage to Closed Sep 25, 2020
@bhulsken bhulsken deleted the metadatagrabber_timeout_extension branch October 7, 2020 10:04
@stuarta stuarta added this to the 32.0 milestone Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Bug Triage
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants