Specify separate metadata grabber languages #29

Open
wants to merge 8 commits into
from

Projects

None yet

3 participants

@rsiebert

This PR adds the option to the metadata grabber settings screen to define separate languages for each of the video, recording or game grabbers. This is useful if the user uses its main language for the frontend but wants to have the video or game metadata information in english only.

@Beirdo Beirdo pushed a commit that referenced this pull request Sep 13, 2013
@wagnerrp wagnerrp Have pager return Nones if the server returns null.
This temporarily resolves an issue where the TheMovieDb server returns
nulls in searches when a movie has been deleted but not yet flushed out
of the cache. This prevents the error internally, but does not attempt
to re-order to remove the nulls, so is merely passing the issue onto the
application using this library.

Refs #29
(cherry picked from commit 0d91e6f)
4d341e7
@Beirdo Beirdo pushed a commit that referenced this pull request Sep 13, 2013
@wagnerrp wagnerrp Have pager return Nones if the server returns null.
This temporarily resolves an issue where the TheMovieDb server returns
nulls in searches when a movie has been deleted but not yet flushed out
of the cache. This prevents the error internally, but does not attempt
to re-order to remove the nulls, so is merely passing the issue onto the
application using this library.

Refs #29
0d91e6f
@Beirdo Beirdo pushed a commit that referenced this pull request Sep 13, 2013
@wagnerrp wagnerrp Have pager return Nones if the server returns null.
This temporarily resolves an issue where the TheMovieDb server returns
nulls in searches when a movie has been deleted but not yet flushed out
of the cache. This prevents the error internally, but does not attempt
to re-order to remove the nulls, so is merely passing the issue onto the
application using this library.

Refs #29
(cherry picked from commit 0d91e6f)
e5656ca
@faginbagin faginbagin added a commit to faginbagin/mythtv that referenced this pull request Oct 8, 2013
@wagnerrp @faginbagin wagnerrp + faginbagin Have pager return Nones if the server returns null.
This temporarily resolves an issue where the TheMovieDb server returns
nulls in searches when a movie has been deleted but not yet flushed out
of the cache. This prevents the error internally, but does not attempt
to re-order to remove the nulls, so is merely passing the issue onto the
application using this library.

Refs #29
(cherry picked from commit 0d91e6f)
265c91e
@wagnerrp wagnerrp was assigned by stuartm Jun 12, 2014
@rsiebert

Any chance of getting this PR included?

@dekarl
Member
dekarl commented Jun 17, 2014

Please file a ticket at https://code.mythtv.org/trac/newticket so this does not get overlooked.

Is there a special reason to use the same setting for movie/tv but a different one for games?
I'm wondering if just one setting for the "preferred language for external data sources" would be enough. That setting could be shared with e.g. mythnetvision, videos, mythbrowser...
Or how about using the existing settings for "preferred language for Program Guide data and captions"?

@rsiebert

The idea behind this settings was that the frontend language and the TV and EPG descriptions are all german (coming over DVB-T), but my movie collection is mainly in english. I wanted to see the english version of the movie title and description, not the german ones.
This setting can certainly be used for the other plugins. But using the setting "preferred language for Program Guide data and captions" does not fit. It should be reserved for the EPG and captions, not the video metadata.

@rsiebert

As jyavenard already said on IRC, I also think the mythtv devs should start using the features of github like xbmc does. Merging this PR and the other ones into their code is easy. Also feature requests and patches can be tracked here.

It's not encouraging at all to add PRs or tickets in trac and they do not get merged, even obvious bug fixes or small enhancements.

I had the new mythgallery plugin PR here (#41) even with trac tickets. It is really not user friendly adding new patches or diffs to a ticket in trac whenever a do a small change to the gallery branch. In github I can just push it and the dev can merge or cherrypick the commit. But thats off topic.

@dekarl
Member
dekarl commented Jun 17, 2014

I do agree that we should either properly use github's pull requests or disable them. There's no point in letting users write into a channel that (almost) no one reads. (personally I prefer we make better use of github's integrated tools, but that's just me. Switching the master repository needs to be discussed with our infrastructure people.)
I do not agree on "just merge it, because its only one click" when we are trying to reduce settings instead of adding new ones without discussing them first.
The EIT code should try to get data in Language1 then Language2 then use whatever comes first. So setting it to prefer english, then german should work. Of course that would change the meaning of that setting, but I don't see a point in preferring the guide in language1 and but preferring looking a recording from that guide in languageX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment