fix issue #10222: mythcommflag segfaulting #37

Merged
merged 1 commit into from Feb 26, 2013

Conversation

Projects
None yet
2 participants
Contributor

thomas-joiner commented Feb 11, 2013

The problem in issue #10222 is that it is adding the CODEC_FLAG2_FAST flag.  This causes unsafe functions to be used, causing a segfault. The proper way to fix this would probably be to figure out how to test for the "experimental speedups" flag, however I don't know the codebase well enough for this.

I tested how this would affect the speed of mythcommflag on one of my recordings.  The results:

Before removing flag:
real 2m13.123s
user 2m16.713s
sys 0m3.502s

After removing flag:
real 2m13.021s
user 2m15.446s
sys 0m3.758s

@thomas-joiner thomas-joiner fix issue #10222: mythcommflag segfaulting
The problem in issue #10222 is that it is adding the CODEC_FLAG2_FAST flag.  This causes unsafe functions to be used, causing a segfault. The proper way to fix this would probably be to figure out how to test for the "experimental speedups" flag, however I don't know the codebase well enough for this.

I tested how this would affect the speed of mythcommflag on one of my recordings.  The results:

Before removing flag:
real 2m13.123s
user 2m16.713s
sys 0m3.502s

After removing flag:
real 2m13.021s
user 2m15.446s
sys 0m3.758s
0026dda

@Beirdo Beirdo merged commit 0026dda into MythTV:master Feb 26, 2013

@sdrik sdrik pushed a commit to sdrik/mythtv that referenced this pull request Dec 29, 2013

@stuarta stuarta Merge remote-tracking branch 'thomas-joiner/bug_10222'
MythTV#37

Refs #10222
Closes #11411

Signed-off-by: Stuart Auchterlonie <stuarta@squashedfrog.net>
aaa5255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment