Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix issue #10222: mythcommflag segfaulting #37

Merged
merged 1 commit into from

2 participants

@thomas-joiner

The problem in issue #10222 is that it is adding the CODEC_FLAG2_FAST flag.  This causes unsafe functions to be used, causing a segfault. The proper way to fix this would probably be to figure out how to test for the "experimental speedups" flag, however I don't know the codebase well enough for this.

I tested how this would affect the speed of mythcommflag on one of my recordings.  The results:

Before removing flag:
real 2m13.123s
user 2m16.713s
sys 0m3.502s

After removing flag:
real 2m13.021s
user 2m15.446s
sys 0m3.758s

@thomas-joiner thomas-joiner fix issue #10222: mythcommflag segfaulting
The problem in issue #10222 is that it is adding the CODEC_FLAG2_FAST flag.  This causes unsafe functions to be used, causing a segfault. The proper way to fix this would probably be to figure out how to test for the "experimental speedups" flag, however I don't know the codebase well enough for this.

I tested how this would affect the speed of mythcommflag on one of my recordings.  The results:

Before removing flag:
real 2m13.123s
user 2m16.713s
sys 0m3.502s

After removing flag:
real 2m13.021s
user 2m15.446s
sys 0m3.758s
0026dda
@Beirdo Beirdo merged commit 0026dda into MythTV:master
@sdrik sdrik referenced this pull request from a commit in sdrik/mythtv
@stuarta stuarta Merge remote-tracking branch 'thomas-joiner/bug_10222'
MythTV#37

Refs #10222
Closes #11411

Signed-off-by: Stuart Auchterlonie <stuarta@squashedfrog.net>
aaa5255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 11, 2013
  1. @thomas-joiner

    fix issue #10222: mythcommflag segfaulting

    thomas-joiner authored
    The problem in issue #10222 is that it is adding the CODEC_FLAG2_FAST flag.  This causes unsafe functions to be used, causing a segfault. The proper way to fix this would probably be to figure out how to test for the "experimental speedups" flag, however I don't know the codebase well enough for this.
    
    I tested how this would affect the speed of mythcommflag on one of my recordings.  The results:
    
    Before removing flag:
    real 2m13.123s
    user 2m16.713s
    sys 0m3.502s
    
    After removing flag:
    real 2m13.021s
    user 2m15.446s
    sys 0m3.758s
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 2 deletions.
  1. +0 −2  mythtv/libs/libmythtv/avformatdecoder.cpp
View
2  mythtv/libs/libmythtv/avformatdecoder.cpp
@@ -1380,8 +1380,6 @@ void AvFormatDecoder::InitVideoCodec(AVStream *stream, AVCodecContext *enc,
FlagIsSet(kDecodeFewBlocks) || FlagIsSet(kDecodeNoLoopFilter) ||
FlagIsSet(kDecodeNoDecode))
{
- enc->flags2 |= CODEC_FLAG2_FAST;
-
if ((AV_CODEC_ID_MPEG2VIDEO == codec->id) ||
(AV_CODEC_ID_MPEG1VIDEO == codec->id))
{
Something went wrong with that request. Please try again.