Send REC_PENDING event before recording starts #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the logic that sends the REC_PENDING event. - REC_PENDING event is sent always before the REC_STARTED. - REC_PENDING event is sent at 120, 90, 60 and 30 seconds before the start of the recording. - Start of the recording is the scheduled program start time plus the RecordPreRoll setting value. - When a recording is scheduled to start recording immediately then there is one REC_PENDING event with 0 seconds immediately followed by the REC_STARTED event. - The setting WakeUpThreshold specifies how early the slave backends are signaled to start before the recording is started. This setting is used as configured, but now with a minimum value of RecordPreRoll plus 120 seconds so that there is always time for the REC_PENDING events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the logic that sends the REC_PENDING event.
one REC_PENDING event with 0 seconds immediately followed by the REC_STARTED event.
before the recording is started. This setting is used as configured, but now with a minimum
value of RecordPreRoll plus 120 seconds so that there is always time for the REC_PENDING events.