{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":634987088,"defaultBranch":"master","name":"aws-sdk-net","ownerLogin":"Mythra","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-05-01T17:55:22.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/7262714?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1688246028.0","currentOid":""},"activityList":{"items":[{"before":"1c4e3c5904718c1955dacea56cec34e37e58e2d4","after":"1b23891432e687e2c86787164a3aac54bf7941ec","ref":"refs/heads/dev/mythra/1977","pushedAt":"2023-12-28T20:09:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"address comments about BCL ClientConfig","shortMessageHtmlLink":"address comments about BCL ClientConfig"}},{"before":"70b6e15b0d790ddbef8217d329c55206573a1a53","after":"1c4e3c5904718c1955dacea56cec34e37e58e2d4","ref":"refs/heads/dev/mythra/1977","pushedAt":"2023-12-07T02:14:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"swap reading explicit over env-var first, tests\n\nEnsure we read explicitly configured proxies through code first,\nand then fallback to reading the proxy from environment variables.\nnext add some tests with the recommended environment variable mocking\ntest setup provided.","shortMessageHtmlLink":"swap reading explicit over env-var first, tests"}},{"before":"5808fded6cc640f9962c7b6c526a823fef985bf4","after":"70b6e15b0d790ddbef8217d329c55206573a1a53","ref":"refs/heads/dev/mythra/1977","pushedAt":"2023-11-29T22:59:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"remove accidental .swp file","shortMessageHtmlLink":"remove accidental .swp file"}},{"before":"7b6b6b8292a536466e821dd67d86c1686c05ebf9","after":"5808fded6cc640f9962c7b6c526a823fef985bf4","ref":"refs/heads/dev/mythra/1977","pushedAt":"2023-11-29T20:26:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"actually parse out credentials for proxy","shortMessageHtmlLink":"actually parse out credentials for proxy"}},{"before":"e04c5cdedab8f62e85206be32337f1ad720aae9d","after":"7b6b6b8292a536466e821dd67d86c1686c05ebf9","ref":"refs/heads/dev/mythra/1977","pushedAt":"2023-07-06T00:52:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"check for `http_proxy` & `https_proxy` env-vars\n\nthis brings us in line with many other AWS SDKs which check for\nthese environment variables to modify client behavior. it does not\nchange behavior if you've already been setting your web proxy\nexplicitly, or in properties (the same as the java (and other) sdks).\n\nwe do introduce this with two new methods in ClientConfig to not break\nany existing callers using the methods that are public. while all of our\ncallers have been updated to properly check web proxy, and then if\nthat's unset check the protocol being used and optionally call\n`GetHttpProxy`/`GetHttpsProxy` as needed. If we're okay with breaking\never IT MAY be worthwhile to break `GetWebProxy` by taking in the\nprotocol, and then just having the one method to prevent any accidental\nmis-use, and to ensure everyone is using those environment variables.\n\nit's also important to note:\n<https://github.com/dotnet/runtime/issues/31113> meaning a user will\njust get an error if they try to proxy to something that is using\n`HTTPS`. i figured just letting it error on construction is probably\nthe 'safest' option. letting the user know that their setting isn't\nbeing respected, as opposed to just silently 'ignoring' it. this is\nalso a decision we might want to change.","shortMessageHtmlLink":"check for <code>http_proxy</code> &amp; <code>https_proxy</code> env-vars"}},{"before":"2f0f8cde3ea7f72b0fbff9d2e553ed18c2443bb4","after":"f94b0eec2b5b1bd1344efc7a235921dd1a84b789","ref":"refs/heads/master","pushedAt":"2023-07-06T00:51:36.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"Commit version number update changes","shortMessageHtmlLink":"Commit version number update changes"}},{"before":"bbfa559e6536846b8a286bd7e5e2800cc80f76eb","after":"e04c5cdedab8f62e85206be32337f1ad720aae9d","ref":"refs/heads/dev/mythra/1977","pushedAt":"2023-07-02T18:50:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"check for `http_proxy` & `https_proxy` env-vars\n\nthis brings us in line with many other AWS SDKs which check for\nthese environment variables to modify client behavior. it does not\nchange behavior if you've already been setting your web proxy\nexplicitly, or in properties (the same as the java (and other) sdks).\n\nwe do introduce this with two new methods in ClientConfig to not break\nany existing callers using the methods that are public. while all of our\ncallers have been updated to properly check web proxy, and then if\nthat's unset check the protocol being used and optionally call\n`GetHttpProxy`/`GetHttpsProxy` as needed. If we're okay with breaking\never IT MAY be worthwhile to break `GetWebProxy` by taking in the\nprotocol, and then just having the one method to prevent any accidental\nmis-use, and to ensure everyone is using those environment variables.\n\nit's also important to note:\n<https://github.com/dotnet/runtime/issues/31113> meaning a user will\njust get an error if they try to proxy to something that is using\n`HTTPS`. i figured just letting it error on construction is probably\nthe 'safest' option. letting the user know that their setting isn't\nbeing respected, as opposed to just silently 'ignoring' it. this is\nalso a decision we might want to change.","shortMessageHtmlLink":"check for <code>http_proxy</code> &amp; <code>https_proxy</code> env-vars"}},{"before":null,"after":"bbfa559e6536846b8a286bd7e5e2800cc80f76eb","ref":"refs/heads/dev/mythra/1977","pushedAt":"2023-07-01T21:13:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"check for `http_proxy` & `https_proxy` env-vars\n\nthis brings us in line with many other AWS SDKs which check for\nthis environment variable, and properly set it. a couple things\nto note about this:\n\n1. I chose to not add in explicit unit tests/integration tests as\nthe webproxy already has tests. and testing an environment\nvariable would bleed into other tests unless we mocked it everywhere,\nor we serially ran those tests that depended on the state of the env\nvar. I think the overhead of either of these is not worth what we\nget out of it (which is effectively two calls to BCL, one for the\nenvironment variable, one for constructing a web proxy). if you want\nme to go through either of these paths, i can.\n\n2. HTTPS proxies were only recently supported in dotnet:\n<https://github.com/dotnet/runtime/issues/31113>. I chose to\n'try to construct, error if it fails'. This techincally introduces\na case where you get an exception being thrown you wouldn't before.\nThis _feels_ like the right path \"hey your https proxy isn't being\nused even though you told us to use it\". I can wrap this in a try\ncatch block though if we decide we just want to silently ignore it\nlike we have been so far (this may lead to more bugs being filed\nabout \"why doesn't https_proxy work!\").","shortMessageHtmlLink":"check for <code>http_proxy</code> &amp; <code>https_proxy</code> env-vars"}},{"before":"da49639efe15f43ae152bb9a6bb9683ffec585f5","after":"2f0f8cde3ea7f72b0fbff9d2e553ed18c2443bb4","ref":"refs/heads/master","pushedAt":"2023-07-01T16:03:29.000Z","pushType":"push","commitsCount":388,"pusher":{"login":"Mythra","name":"Cynthia Coan","path":"/Mythra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7262714?s=80&v=4"},"commit":{"message":"Commit version number update changes","shortMessageHtmlLink":"Commit version number update changes"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMi0yOFQyMDowOTowNy4wMDAwMDBazwAAAAPTqdu7","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNy0wMVQxNjowMzoyOS4wMDAwMDBazwAAAANM2tLP"}},"title":"Activity · Mythra/aws-sdk-net"}