Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Eliminate repeated enumerations #75
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
These four enumerations are all the same thing. This appears to be the only case of an enum replicated across multiple classes within the main code base. There is some replication in bringing in enumerations from QextSerialPort, but changing that would require less maintainable code in the relevant selector widgets so this should be kept until it is reasonable to switch to either a version of QextSerialPort that makes its enumerations discoverable through the meta-object system or if the QtSerialPort module gets into a stable release it may be possible to similarly trim things down.
While I don't like its current existence in the DAQ class, DAQ::ThermocoupleType does not appear to be replicated elsewhere at present.