Error codes #108
Merged
Error codes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
No idea why there is a file conflict? Also one could consider raising an exception if the login fails (without debug: just exception, with debug: exception with error message, for example) |
|
I am sure the conflict is because I commit the logout integration before your PR, I will have a look today |
N4S4
approved these changes
Jan 12, 2023
|
Looks great, merging to the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reworked the authentication structure, stream lined some duplicate code and added also a error code check for
request_data()In general I don't think
login()has to return something which is then checked for debug in every station API just to print that, but in that caselogin()can just directly print if debug is active