Permalink
Commits on Feb 17, 2012
  1. Fix crash report when SFTP connection is closed very fast

    In the SFTP client if the socket is successfully created, but is immediately
    closed, even before the code gets to the inet:peername call, there's a huge
    crash report. This commit handles this error: adds a new initial state
    ('uninitialized') to the ssh_connection_handler and the peername call is made
    in this state. The start_link sends an event immediately after the FSM start,
    which is handled in the new uninitialized state. If the peername call is
    successful, the FSM goes to the hello state and everything works as it used to
    be. If it's not successful, the FSM terminates. The reason why I introduced
    this new state is that I couldn't stop the FSM from the init function without
    crash reports, but with a good error value. The rest of the commit is just a
    bunch of case statements to propagate the error.
    Attila Rajmund Nohl committed Feb 16, 2012
  2. Fix SSH crash report when user's password is expired

    We get the following crash report when the Erlang SFTP client wants to connect
    to a server with disabled user interaction, but the user's password is expired:
    
    === CRASH REPORT #218783 == <6342.44.0> == 2012-02-06 10:00:50 =================
    node: server_00054_GSM_STN_T11A-SIU02@netsimlin248
    type: crash_report
    [{initial_call,{ssh_connection_handler,init,['Argument__1']}},
     {pid,<6339.7689.2>},
     {registered_name,[]},
     {error_info,
         {exit,
             {bad_return_value,{no_io_allowed,format}},
             [{gen_fsm,terminate,7},{proc_lib,init_p_do_apply,3}]}},
    
    This commit fixes the crash report and produces better error messages.
    Attila Rajmund Nohl committed Feb 16, 2012
  3. Some observer fixes

     - when canceling in Edit Object window 'cancel' atom is expected to be returned
     - when parsing edited object according to erl_parse docs "token list
       must end with the dot token"; ensure this is always true
     - handle parse errors in edited objects
     - handle invalid regexp in search
     - MEssageDialog error terms even if they are not strings
     - show printable strings in objects instead of integer lists (like old
       tv did) (ugly: 9999 terminal width)
    Attila Rajmund Nohl committed Feb 16, 2012
  4. Fix crash reports on sending SSH closing message

    This commit fixes crash reports when the Erlang side tried to send a closing
    message on an already closed channel.
    Attila Rajmund Nohl committed Feb 16, 2012
  5. Fix crash reports when client already closes channel

    Under heavy load with the Maverick client it happens quite often that
    the Erlang SSH server is in the process of answering an EOF when the
    channel is already closed. This leads to many big scary (and misleading)
    error reports. This commit solves the problem.
    Attila Rajmund Nohl committed Feb 16, 2012
  6. Fix 100+MB uploads from Maverick SFTP client

    Uploading huge files (100+MB) doesn't work with Maverick (similar
    problems with ssh-0.9.9.6). The fix: only send adjust messages if the window
    size is below 50%.
    Attila Rajmund Nohl committed Feb 16, 2012
  7. Fix resolving NamingService references with IPv6 addresses

    Attila Rajmund Nohl committed Feb 16, 2012
Commits on Feb 16, 2012
  1. @bjorng

    Update primary bootstrap

    bjorng committed Feb 16, 2012
  2. @bjorng

    Merge branch 'bjorn/compiler/inline-and-on_load/OTP-9910' into maint

    * bjorn/compiler/inline-and-on_load/OTP-9910:
      compiler: Teach the inliner to preserve on_load functions
    bjorng committed Feb 16, 2012
  3. @proxyles

    Merge branch 'ahs/fix-gb_trees-doc' into maint

    * ahs/fix-gb_trees-doc:
      Put gb_trees documentation into alphabetical order
    
    OTP-9929
    proxyles committed Feb 16, 2012
  4. @proxyles

    Merge branch 'vd/jinterface-atom-message' into maint

    * vd/jinterface-atom-message:
      Improve error message when creating a too long OtpErlangAtom
    
    OTP-9928
    proxyles committed Feb 16, 2012
  5. @proxyles

    Merge branch 'vd/java-string-bug' into maint

    * vd/java-string-bug:
      add test for Java string bug
      workaround for Java bug http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6242664
    
    OTP-9927
    proxyles committed Feb 16, 2012
  6. @proxyles

    Merge branch 'jz/erts-remove-unused-var' into maint

    * jz/erts-remove-unused-var:
      erts: Remove unused variable
    
    OTP-9926
    proxyles committed Feb 16, 2012
  7. @proxyles

    Merge branch 'rc/spell-registered' into maint

    * rc/spell-registered:
      Correct spelling of "registered" in various places in the source code
    
    OTP-9925
    proxyles committed Feb 16, 2012
  8. @proxyles

    Merge branch 'rj/fix-sup-doc-typo' into maint

    * rj/fix-sup-doc-typo:
      Fix typo in supervisor behaviour doc
    
    OTP-9924
    proxyles committed Feb 16, 2012
  9. @proxyles

    Merge branch 'ts/extend-specs-for-bifs' into maint

    * ts/extend-specs-for-bifs:
      Make dialyzer recognize the process_flag option sensitive
    
    OTP-9923
    proxyles committed Feb 16, 2012
  10. @proxyles

    Merge branch 'rj/fix-binary-doc-spec' into maint

    * rj/fix-binary-doc-spec:
      Fix the type spec from the doc of binary:part/3
    
    OTP-9920
    proxyles committed Feb 16, 2012
  11. @proxyles

    Merge branch 'rj/fix-compile-doc-typo' into maint

    * rj/fix-compile-doc-typo:
      Fix typo in `compile' doc: unmatched parenthesis
    
    OTP-9919
    proxyles committed Feb 16, 2012
  12. @proxyles

    Merge branch 'rj/doc-monospace-css' into maint

    * rj/doc-monospace-css:
      Set `font-family: Courier, monospace' in OTP doc CSS
    
    OTP-9918
    proxyles committed Feb 16, 2012
  13. @IngelaAndin

    Merge branch 'ia/ssh/server-user-dir-doc' into maint

    * ia/ssh/server-user-dir-doc:
      Document user_dir for the server
    IngelaAndin committed Feb 16, 2012
  14. @IngelaAndin

    Merge branch 'ia/ssh/pass-phrase-protected-keys/OTP-6400' into maint

    * ia/ssh/pass-phrase-protected-keys/OTP-6400:
      Remove unused files from test data as it is confusing
      Add support for key files protected by pass phrases
    IngelaAndin committed Feb 16, 2012
Commits on Feb 15, 2012
  1. @IngelaAndin
  2. @IngelaAndin
Commits on Feb 14, 2012
  1. Change test to use CT Config PrivDir

    Gustav Simonsson committed Feb 14, 2012
  2. @IngelaAndin
  3. @IngelaAndin

    Merge branch 'ia/ssh/crash-report-with-impatient-SFTP-client/OTP-9391…

    …' into maint
    
    * ia/ssh/crash-report-with-impatient-SFTP-client/OTP-9391:
      Avoid to crash if the remote side closes the connection prematurely
    IngelaAndin committed Feb 14, 2012
  4. @IngelaAndin

    Merge branch 'ia/ssh/keyboard-interactive-disable-bug/OTP-9466' into …

    …maint
    
    * ia/ssh/keyboard-interactive-disable-bug/OTP-9466:
      Client now honors the allow_user_interaction option
    IngelaAndin committed Feb 14, 2012
  5. Merge branch 'gustav/asn1-integer/sequence-fix/OTP-9688' into maint_w…

    …ith_asn1
    Gustav Simonsson committed Feb 14, 2012
  6. Merge branch 'gustav/ssh/ssh-key-callback-specs' into maint

    * gustav/ssh/ssh-key-callback-specs:
      Add behaviour (api) module with callback specs
    Gustav Simonsson committed Feb 14, 2012
  7. Merge branch 'gustav/orber/fix-dbg-printout-format/OTP-9887' into maint

    * gustav/orber/fix-dbg-printout-format/OTP-9887:
      Add parameter to error message string format
    Gustav Simonsson committed Feb 14, 2012
  8. Merge branch 'gustav/sasl_release_handler_file_bugfix/OTP-9864' into …

    …maint
    
    * gustav/sasl_release_handler_file_bugfix/OTP-9864:
      Fix so remove_release can remove symlinks
    Gustav Simonsson committed Feb 14, 2012
  9. @proxyles

    Merge branch 'pg/fix-ssl_tls_dist_proxy-setup-loop' into maint

    * pg/fix-ssl_tls_dist_proxy-setup-loop:
      Fix setup loop of SSL TLS dist proxy
    
    OTP-9915
    OTP-9916
    proxyles committed Feb 14, 2012
  10. @proxyles

    Merge branch 'pg/ssl_dist-fixes' into maint

    * pg/ssl_dist-fixes:
      Robustness and improvement to distribution over SSL
    proxyles committed Feb 14, 2012
  11. @pguyot @proxyles

    Robustness and improvement to distribution over SSL

    Fix a bug where the caller would timeout and ssl_tls_dist_proxy would
    crash.
    Fix a bug where a timeout from the SSL layer would block the
    distribution forever (typically when a non-SSL node tries to connect to an
    SSL node).
    Add this very case as a test (test_server tries to connect to SSL nodes).
    Run the proxy exclusively on the loopback interface.
    pguyot committed with proxyles Jan 16, 2012