Skip to content
Permalink
Browse files
Fix specs
  • Loading branch information
NARKOZ committed Jun 13, 2020
1 parent 353004b commit 46343c91940df46d773e564ba974a1331c88590d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
@@ -303,7 +303,7 @@

it 'posts the correct resource' do
expect(a_post('/projects/3/merge_requests/2/discussions')
.with(body: 'body=Discussion&position[old_line]=1')).to have_been_made
.with(body: 'body=Discussion&position[old_line]=1'.gsub('[', '%5B').gsub(']', '%5D'))).to have_been_made
end

it 'returns information about the discussions' do
@@ -67,7 +67,7 @@

it 'calls with the correct body' do
expected_body = 'variables[][key]=VAR1&variables[][value]=value&variables[][key]=VAR2&variables[][value]=value'
expect(a_post(pipeline_path).with(body: expected_body)).to have_been_made
expect(a_post(pipeline_path).with(body: expected_body.gsub('[', '%5B').gsub(']', '%5D'))).to have_been_made
end
end
end

1 comment on commit 46343c9

@boutil
Copy link

@boutil boutil commented on 46343c9 Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is needed for httparty >= 0.18.
Shouldn't you bump the minimal version of httparty in gemspec?

Please sign in to comment.