Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full uniform resource names with generated SIPs and AIPs from PDS Registry #156

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

nutjob4life
Copy link
Member

🗒️ Summary

Use full uniform resource names when generating SIPs and AIPs from PDS Registry. When "validate" is run on these files, the invalid LIDVID error now goes away.

The issue of CRLF line endings is being addressed separately.

⚙️ Test Data and/or Report

Not necessary thanks to pre-commit hooks, but see also this:


PDS Validate Tool Report

Configuration:
   Version     3.5.0-SNAPSHOT
   Date        2024-02-01T19:12:26Z

Parameters:
   Targets                      [file:/Users/kelly/Desktop/CRLF/magellan_gxdr_v1.0_20240201_aip_v1.0.xml, file:/Users/kelly/Desktop/CRLF/magellan_gxdr_v1.0_20240201_sip_v1.0.xml]
   Severity Level               WARNING
…
Product Level Validation Results

  FAIL: file:/Users/kelly/Desktop/CRLF/magellan_gxdr_v1.0_20240201_aip_v1.0.xml
    Begin Content Validation: file:/Users/kelly/Desktop/CRLF/magellan_gxdr_v1.0_20240201_transfer_manifest_v1.0.tab
      ERROR  [error.table.missing_CRLF]   data object transfer manifest or index 1, record 1: Record does not end in carriage-return line feed.
      ERROR  [error.table.missing_CRLF]   data object transfer manifest or index 1, record 2: Record does not end in carriage-return line feed.
      ERROR  [error.table.missing_CRLF]   data object transfer manifest or index 1, record   PASS: file:/Users/kelly/Desktop/CRLF/magellan_gxdr_v1.0_20240201_sip_v1.0.xml
…
        2 product validation(s) completed

Summary:

  2 product(s)
  109 error(s)
  0 warning(s)

  Product Validation Summary:
    1          product(s) passed
    1          product(s) failed
    0          product(s) skipped
    2          product(s) total

  Referential Integrity Check Summary:
    0          check(s) passed
    0          check(s) failed
    0          check(s) skipped
    0          check(s) total

  Message Types:
    109          error.table.missing_CRLF

End of Report
Completed execution in 10762 ms

♻️ Related Issues

@jordanpadams jordanpadams merged commit ead418a into main Feb 8, 2024
1 check passed
@jordanpadams jordanpadams deleted the i155 branch February 8, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants