Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to keep track of superseded products to avoid false warnings #615

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Not the most comprehensive XML parsing but the shortest road to fix the bug. It can be cleverly circumvented with XML comments. To fix this, if it ever becomes and issue, is to introduce XML DOM parsing and XPATH for finding the tags. Unnecessary work for cooperative opponents but required for adversarial opponents.

⚙️ Test Data and/or Report

See github597 in unit testing.

♻️ Related Issues

Closes #597

Al Niessner added 2 commits March 15, 2023 12:27
While not using an XML library, using the open and closing tags to find all file references and then add them to a skipped list to prevent the warning that there are files not referenced.
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Mar 27, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/615.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/615.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jordanpadams jordanpadams merged commit 3567ea3 into main Mar 30, 2023
@jordanpadams jordanpadams deleted the issue_597 branch March 30, 2023 23:13
@jordanpadams jordanpadams changed the title Issue 597: find resources in older versions Update to keep track of superseded products to avoid false warnings Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants