Updates for including data object names in error messages and enhance test suite with additional table types #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add unit test first Seems the problem is already fixed
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
* add unit test * cleanup test data
In both Array and Tables if a name is given then that will be used as well as the index to identify it. Not sure that matches what is really desired, but it seems more meaningful than just the name or just the index value. I had seen them many of times and had no idea that it was the index in the XML file.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
src/main/java/gov/nasa/pds/tools/validate/content/table/TableContentProblem.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nasa/pds/tools/validate/content/table/TableContentProblem.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nasa/pds/tools/validate/content/array/ArrayContentProblem.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nasa/pds/tools/validate/content/array/ArrayLocation.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/640.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/640.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
…ontentProblem.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…ontentProblem.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…ontentProblem.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
…ocation.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
Repaired what sonatype automatically fixed but got wrong. Not much, but still requires manual cleanup.
jordanpadams
requested changes
May 11, 2023
jordanpadams
changed the title
… validated (#642) * add unit tests * update unit test --------- Co-authored-by: Al Niessner <Al.Niessner@xxx.xxx>
jordanpadams
approved these changes
May 11, 2023
This was referenced May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Brief summary of changes if not sufficiently described by commit messages.
⚙️ Test Data and/or Report
One of the following should be included here:
♻️ Related Issues
#534
#343
#217
#190