Handle bundle/collection files as input with bundle/collection rule #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 31, 2023 09:45
Found the existing code used TargetExaminer to determine if a target is a bundle or collection so got rid of the same checks in AggregateManager and moved the code to use the check for better uniform behavior.
Found the existing code used TargetExaminer to determine if a target is a bundle or collection so got rid of the same checks in AggregateManager and moved the code to use the check for better uniform behavior.
Found the existing code used TargetExaminer to determine if a target is a bundle or collection so got rid of the same checks in AggregateManager and moved the code to use the check for better uniform behavior.
Found the existing code used TargetExaminer to determine if a target is a bundle or collection so got rid of the same checks in AggregateManager and moved the code to use the check for better uniform behavior.
Upgraded AggregationManager to handle bundle and collection XML files instead of just directories. Still end up with lots of skipped files if they exist in the directories because that is hard to fix. Would have to process the older versions like when a directory is specified to build up the list of older versions or do some other strange processing to know they are old versions at the place where the skipped files pop up. Seems like the skipped messages should remain because they tell the user that validate knows they are there but not part of the collection/bundle that they were specifically told to process.
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/656.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/656.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
jordanpadams
approved these changes
Jun 14, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
The current behavior was inconsistent and the users wanted to specify bundle/collection files. Reworked AggregateManager (mostly) to support the user desire and make the handling consistent for them both.
⚙️ Test Data and/or Report
See unit tests below.
♻️ Related Issues
Close #649