Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated WorldWind Android documentation #146

Merged
merged 5 commits into from Aug 17, 2017

Conversation

eirizarry
Copy link
Contributor

@eirizarry eirizarry commented Aug 16, 2017

This pull request is required to update the contribution documentation in the WorldWind Android repository.

Files added:

  • ISSUE_TEMPLATE.md, which outlines the expectations for submitting an issue
  • PULL_REQUEST_TEMPLATE.md, which outlines the expectations for submitting a pull request
  • CONTRIBUTING.md, which outlines the expectations for contributing and resources available for WorldWind Android

My only additional comment about the CONTRIBUTING.md file is that it does not include the design/coding guidelines that are available in the other WorldWind repositories. My thoughts are to add the CONTRIBUTING.md file as is now, but update it with the design/coding guidelines later.

Closes #141, closes #142, closes #143.

- This file outlines the expectations and guidelines for contributing to WorldWind Android.
- It is much like the other CONTRIBUTING.md files in WorldWind's other repository, except for the lack of design and coding guidelines.
The heading read "Contributing to Web WorldWind" and has been changed to "Contributing to WorldWind Android"
@eirizarry eirizarry self-assigned this Aug 16, 2017
@eirizarry eirizarry requested a review from pdavidc August 16, 2017 17:22
@ghost ghost added the needs review label Aug 16, 2017
@eirizarry eirizarry added task and removed task labels Aug 16, 2017
- The link removed led to Web WorldWind, rather than WorldWind Android.
Copy link
Contributor

@pdavidc pdavidc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pdavidc pdavidc merged commit 765863f into develop Aug 17, 2017
@pdavidc pdavidc deleted the feature/update-documentation branch August 17, 2017 20:13
@ghost ghost removed the needs review label Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add PR_TEMPLATE.md Add ISSUE_TEMPLATE.md Add CONTRIBUTING.md
2 participants