OpenAlias support #213
Merged
OpenAlias support #213
Conversation
adds function to generate a random string of a given length
adds function to generate a random string of a given length
…navcoin-core into v4.2.0-open-alias
aguycalled
requested review from
zanuka,
red010b37,
proletesseract,
ro-savage and
matt-auckland
|
Don't want to add any more to v 4.2.0-rc, this should be its own minor release |
| @@ -54,13 +70,15 @@ namespace | |||
| * the unbound library. | |||
| */ | |||
|
|
|||
| #ifdef HAVE_UNBOUND | |||
red010b37
Jun 18, 2018
Member
what does HAVE_UNBOUND relate to in this context?
what does HAVE_UNBOUND relate to in this context?
aguycalled
Jun 19, 2018
Author
Member
if the library unbound is present we will use it to resolve the dns entry instead of dns over https
if the library unbound is present we will use it to resolve the dns entry instead of dns over https
| * | ||
| * @return a navcoin address (as a string) or an empty string | ||
| */ | ||
| std::vector<std::string> addresses_from_url(const std::string& url, bool& dnssec_valid) |
red010b37
Jun 18, 2018
Member
Should we have a test for this?
Should we have a test for this?
| curl_easy_cleanup(curl); | ||
|
|
||
| if (httpCode == 200) { | ||
| UniValue request; |
red010b37
Jun 18, 2018
Member
There seem to be a lot of ways to get addresses. Is this correct? as we seem to be just calling https://dns.google.com/resolve
What is the common path through here?
There seem to be a lot of ways to get addresses. Is this correct? as we seem to be just calling https://dns.google.com/resolve
What is the common path through here?
red010b37
Jun 18, 2018
Member
or are we just returning an empty vector on error?
or are we just returning an empty vector on error?
aguycalled
Jun 19, 2018
Author
Member
exactly, an empty vector is returned when no result is found (whatever the reason for this is)
exactly, an empty vector is returned when no result is found (whatever the reason for this is)
| LogPrintf("DNSSEC not available for checkpoint update at URL: %s, skipping.", url); | ||
| } | ||
| if (!valid[cur_index]) | ||
| bool dns_records_match(const std::vector<std::string>& a, const std::vector<std::string>& b) |
red010b37
Jun 18, 2018
Member
and a test for this as double for loops can be a pain
and a test for this as double for loops can be a pain
aguycalled
added a commit
to skreener/navcoin-core
that referenced
this pull request
Feb 3, 2019
OpenAlias support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR completes the implementation of the open alias protocol in the NavCoin Core client.
OpenAlias is an standard created by the Monero Core project used in the Monero wallet and some other clients like Bitcoin Electrum which allows to translate email addresses into cryptocurrency addresses using custom TXT entries in the DNS records of a domain.
More details about the specification can be found at www.openalias.org
Part of the code is based in the original Monero implementation. Main differences are:
Other modifications in the NavCoin client: