Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnemonic support #400

Merged
merged 17 commits into from Mar 28, 2019
Merged

Mnemonic support #400

merged 17 commits into from Mar 28, 2019

Conversation

@aguycalled
Copy link
Member

aguycalled commented Jan 20, 2019

This PR adds a new RPC command to export the existing master private key encoded as a mnemonic:

dumpmnemonic

It admits an argument specifying the language.

Support for two new wallet options (-importmnemonic and -mnemoniclanguage) have also been added to allow to create a new wallet from the specified mnemonic.

Testing needed.

dy5es41 and others added 5 commits Jan 15, 2019
aguycalled added 5 commits Jan 20, 2019
@matt-auckland

This comment has been minimized.

Copy link
Member

matt-auckland commented Jan 22, 2019

cACK, will test this when I have spare time

}


//long_hash decode_mnemonic(const word_list& mnemonic,

This comment has been minimized.

Copy link
@matt-auckland

matt-auckland Jan 22, 2019

Member

Is there a reason we need to leave this code in?

@@ -150,13 +150,13 @@ NavCoinGUI::NavCoinGUI(const PlatformStyle *platformStyle, const NetworkStyle *n
prevBlocks(0),
spinnerFrame(0),
fDontShowAgain(false),
lastDialogShown(0),
unlockWalletAction(0),
lockWalletAction(0),
toggleStakingAction(0),

This comment has been minimized.

Copy link
@matt-auckland

matt-auckland Jan 22, 2019

Member

What is this code for?

@@ -25,7 +25,6 @@ NavTechInit::~NavTechInit()
void NavTechInit::ShowNavtechIntro(bool exitAfter)
{
NavTechInit navtechinit;

This comment has been minimized.

Copy link
@matt-auckland

matt-auckland Jan 22, 2019

Member

What is this code for?

@proletesseract

This comment has been minimized.

Copy link
Member

proletesseract commented Jan 25, 2019

@matt-auckland going to evaluate functionality and report back

@matt-auckland matt-auckland added this to the 4.5.2 milestone Jan 31, 2019
@marcus290

This comment has been minimized.

Copy link
Contributor

marcus290 commented Feb 14, 2019

I manually tested dumpmnemonic in different languages and -importmnemonic and -mnemoniclanguage and it works for me.

Just wondering, why not add support for the remaining languages that are already in dictionary.cpp?

I also think 8051262 maybe should be moved out to a separate commit.

aguycalled and others added 5 commits Feb 25, 2019
This reverts commit 70f41f2.
This reverts commit 9d56a55.
This reverts commit 1bdd883.
Copy link
Contributor

marcus290 left a comment

pending Travis

Copy link
Member

matt-auckland left a comment

I tested with English and Japanese.
Seems to work fine
I checked if it would fail if I mixed languages
I checked if it would fail if I used an incorrect spelling in the mnemonic
I checked if it would work if I used the wrong number of words

@aguycalled aguycalled merged commit 375c657 into navcoin:master Mar 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.